Skip to content

Test for cookie case #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmurvihill wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test for cookie case #882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8122522
test(cookies): add test for cookie name case not being respected
caarmen Feb 2, 2026
5e41a0a
fix(cookies): incorrect case matching in cookie names
dmurvihill Feb 13, 2026
fe4519a
test(cookies): reorganize test for clarity
dmurvihill Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/cookies/assertion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ module.exports = function (secret, asserts) {
return;
}

const key = part.substr(0, equalsIndex).trim().toLowerCase();
const rawKey = part.substr(0, equalsIndex).trim();
const key = i === 0 ? rawKey : rawKey.toLowerCase();
// only assign once
if (typeof cookie[key] !== 'undefined') return;

Expand Down
22 changes: 22 additions & 0 deletions test/cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,4 +1281,26 @@ describe('cookie', function () {
});
});
});

describe('Cookie name case is respected', function () {

@A1exKH A1exKH Feb 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this version of code to make it clearer:

describe('Cookie Case Sensitivity', function () {

it('should respect capital letters in cookie names', async function () {

@dmurvihill dmurvihill Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to respects case of cookie name and moved up with the rest of the tests for .set.

it('asserts true if cookie name contains capital letters', function () {
const app = express();
app.get('/users', function(req, res) {
res.cookie('Alpha', 'one', { domain: 'domain.com', path: '/', httpOnly: true });
res.send(200, { name: 'tobi' });
});
request(app)
.get('/users')
.expect('Content-Type', /json/)
.expect('Content-Length', '15')
.expect(200)
// assert 'Alpha' cookie is set with domain, path, and httpOnly options
.expect(cookies.set({ name: 'Alpha', options: ['domain', 'path', 'httponly'] }))

@A1exKH A1exKH Feb 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmurvihill could you share more details about this code, please?
As I can see cookies.set and cookies is not a standard global object in Supertest.

In standard Supertest, you cannot pass an object like { name: 'Alpha' } directly into .expect(). Instead, you have to parse the Set-Cookie header string.
Here you can find some details:
#665

@dmurvihill dmurvihill Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cookies was added in supertest 7.2 (#855). See cookies.set.

.end(function(err, res) {
if (err) {
throw err;
}
});
});
});
});
Loading