Skip to content

Added prefix option for agents #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thann wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added prefix option for agents #465

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02aa70f
Added prefix option for agents
Thann Mar 7, 2018
5b6b2a8
Merge remote-tracking branch 'og/master' into prefix
Thann May 18, 2018
653a977
Add positive test case for prefix
Thann May 18, 2018
56fdd82
Merge branch 'master' into prefix
Thann May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function TestAgent(app, options) {
this._ca = options.ca;
this._key = options.key;
this._cert = options.cert;
this._prefix = options.prefix;
}
Agent.call(this);
this.app = app;
Expand All @@ -43,7 +44,8 @@ TestAgent.prototype.__proto__ = Agent.prototype;
// override HTTP verb methods
methods.forEach(function(method) {
TestAgent.prototype[method] = function(url, fn) { // eslint-disable-line no-unused-vars
var req = new Test(this.app, method.toUpperCase(), url);
// TODO: support prefix on actual urls
var req = new Test(this.app, method.toUpperCase(), (this._prefix || '') + url);
req.ca(this._ca);
req.cert(this._cert);
req.key(this._key);
Expand Down
11 changes: 11 additions & 0 deletions test/supertest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,17 @@ describe('request.agent(app)', function() {
});
});

describe('request.agent(app, {prefix})', function() {
it('should apply prefix', function(done) {

@oprogramador oprogramador May 17, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide a successful test (e.g. with 200 status code) as well?

@Thann Thann May 17, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I can't believe I didn't do that already!

var app = express();
var agent = request.agent(app, { prefix: '/api' });

agent
.get('/dummy')
.expect(404, 'Cannot GET /api/dummy\n', done);
});
});

describe('.<http verb> works as expected', function() {
it('.delete should work', function (done) {
var app = express();
Expand Down