Repository navigation
Conversation
|
Side note...I have no more planned edits unless requested until V2 is released and I can help resolve bug reports as they arrive, if any. |
|
I think the last review had many false claims. Updated one:
|
Mirrors the retry-with-backoff patterns already used by ifx/win32.ts and gfortran/darwin.ts, applied to ifort/win32.ts, aocc/debian.ts, and flang/darwin.ts's download and brew-install calls, plus lfortran/debian.ts's conda create (already had a shared retry helper, just wasn't using it). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Addresses review: destination is no longer optional in downloadToolWithRetry (removes the dead cleanup guard), and brewInstallWithRetry now passes --skip-post-install like gfortran's does. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
f22ef24 to
11d4609
Compare
|
Thanks for catching this and correcting the earlier review — appreciated. I'd actually already started hoisting
Agreed on leaving the hoist out of this PR. Happy to open that separately later if there's interest — your point about |
|
CI's |
Extends the retry-with-backoff protection already present in some installers (ifx/win32.ts, gfortran/darwin.ts) to a few that were missing it entirely.
ifort/win32.ts: wraps the Windows installer download in retry — previously a single, unprotected attempt against the same Intel host that failed in Complete Rewrite: Major upgrade tov2#245.aocc/debian.ts: wraps the.debdownload in retry; also removes a comment that inaccurately claimed built-in resilience.flang/darwin.ts: wraps both its GitHub-releases download andbrew install flangin retry.lfortran/debian.ts: swaps a bareconda createcall for thecondaCreateWithRetryhelper already used by the Windows/macOS versions of this same installer.8 new tests covering retry-success and give-up-after-3-attempts for each.
The 6 failing
ifortmacOS checks on the fork validation run (djkees#10) were a pre-existing, unrelated Intel DNS outage (getaddrinfo ENOTFOUND registrationcenter-download.intel.comagainstdarwin.ts, which this PR doesn't touch) — not caused by this change.