fix(AuthFlowTesterUITests): remove beacon RTR workaround (W-24028119) - #3025
Merged
Merged
Conversation
…1480 server fix The server bug that caused beacon apps to unconditionally rotate the refresh token on every refresh (W-23971480) has been fixed in sdb38. Drop the beacon_ clause from expectsRefreshTokenRotation and clean up the related comment in AuthFlowTest so beacon_opaque and beacon_jwt tests no longer expect rotation.
wmathurin
force-pushed
the
remove-beacon-rtr-workaround
branch
from
September 2, 2026 03:57
236a899 to
5bd2982
Compare
Contributor
Author
|
The |
brandonpage
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
beacon_clause fromexpectsRefreshTokenRotationinUITestConfig.ktand cleans up the related comment inAuthFlowTest.kt.The server bug (W-23971480) that caused beacon apps to unconditionally rotate the refresh token on every refresh has been fixed in sdb38. The workaround and its comment are no longer needed —
beacon_opaqueandbeacon_jwttests should now pass without the special-case RTR expectation.Test plan
BeaconLoginTests.testBeaconOpaque_DefaultScopes— was failing with RTR mismatch, now passes