Repository navigation
Support for tab pages - #18
Merged
Merged
Conversation
fnune
approved these changes
Apr 10, 2026
fnune
left a comment
fnune
left a comment
Owner
There was a problem hiding this comment.
Looks good to me. I realize I forgot to make a release for your 1.2.1 fix, so maybe this can go into 1.2.1 and then I'll tag?
Comment on lines
+47
to
+74
| M.set_cursor_for_mark_in_window(0, mark) | ||
| M.set_cursor_for_mark_in_location(0, 0, mark) |
Owner
There was a problem hiding this comment.
Nit/off-topic: the naming and signature is getting a bit convoluted (I started this, though).
set_cursor_for_mark_in_locationseems to be the lower-level tool. Maybe just call itset_cursor_for_mark(...)?- But also
set_cursor_for_markreads strange. Maybego_to_mark? We could rename the others then? - I don't like it when scalar arguments go one after another. One could easily get confused and pass
(winid, tabid)instead of(tabid, winid). Should we take a table with fieldswinidandtabidto avoid confusion?
Owner
There was a problem hiding this comment.
Note that this could be done as a separate PR, it's not really on-topic here.
Owner
|
@bvdmitri bump |
…ark(loc, mark)
Replace set_cursor_for_mark_in_location(tab, win, mark) and
set_cursor_for_mark_in_current_window(mark) with one function that takes
a {tab, win} table. Pass nil from find_first_buf_location when no window
is found, naturally meaning "stay in current tab/window".
Contributor
Author
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation now searches across all tab pages when jumping to a mark, switching to the correct tab page if the target buffer is already displayed there. Previously the navigation didn't work at all or was super glitchy if marks were present in different tabs.
3333.mov