Repository navigation
Fix fuzzy search over marks with telescope - #12
Conversation
fnune
left a comment
There was a problem hiding this comment.
Looks good to me, but would appreciate the legibility change if it does work. You can merge once that's done or you find it doesn't work the way I suggested.
630a57f to
6f7ad0d
Compare
|
Looks like I added tests for this 👀 unexpected. |
|
@Danthewaann before we merge (and sorry about backtracking): isn't this an absolute path? Should we default to a path relative to Neovim's content root path? |
Do you mean instead of creating test files under |
|
I'm suggesting a change in the actual functionality: instead of showing |
|
Would doing this break global marks for files that are outside of the directory where neovim was launched? We could check if each file is relative to the current directory before converting it to a relative path. If a file isn't relative to the current directory we still render it as an absolute path so nothing breaks? |
|
Lints are failing, but once that's good let's merge? |
|
Thanks @Danthewaann ! |
Fixes #11
The
ordinalvalue should be the same as thedisplayvalue to support fuzzy search.I also added some extra info (mark character and line number) to each entry to make them more unique incase you have multiple marks set in a single file e.g.
A:/Users/me/Workspace/notes.md:1.