feat: add upvote functionality for learning paths#193
feat: add upvote functionality for learning paths#193sebmuehlbauer wants to merge 1 commit intofnplus:masterfrom
Conversation
sebmuehlbauer
force-pushed
the
pangea/fix-issue-20
branch
from
3bc4efd to
290e943
Compare
sebmuehlbauer
force-pushed
the
pangea/fix-issue-20
branch
from
290e943 to
c9efaab
Compare
|
@codex Review this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9efaab966
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const UPVOTE_PATH = gql` | ||
| mutation UpvotePath($pathId: Int!, $userId: String!) { | ||
| update_learning_path_by_pk(pk_columns: {id: $pathId}, _append: {voted_by: [ $userId ]}) { |
There was a problem hiding this comment.
This mutation uses update_learning_path_by_pk with _append on voted_by, but the rest of this codebase consistently targets Learning_Paths plus a separate votes relation (for example, src/components/EditPath/editPath.js mutates update_Learning_Paths and src/pages/search.js reads votes/votes_aggregate), so this operation does not match the existing schema shape and upvote requests will fail at runtime when invoked.
Useful? React with 👍 / 👎.
| if (votedBy.includes(userId)) { | ||
| message.info('You have already upvoted this path!'); |
There was a problem hiding this comment.
The duplicate guard checks only the incoming votedBy prop, but this component never updates local state after a successful mutation; if the user clicks again before parent data refreshes, the check still passes and another upvote mutation is sent, which can record duplicate votes for the same user and inflate counts.
Useful? React with 👍 / 👎.
|
@sebmuehlbauer Please check these review comments and see if the PR needs any changes |
2 participants
Fixes #20
This PR introduces an
UpvoteButtoncomponent that allows authenticated users to upvote learning paths.upvoted_byfield (JSON/Array storage) in the database.This PR was autonomously generated by Pangea 3 — an AI-powered development system.