Fix: Allow toggling dynamic log links for Ray, Dask, Spark plugins#7193
Open
Fix: Allow toggling dynamic log links for Ray, Dask, Spark plugins#7193
Conversation
Signed-off-by: Fabio Grätz <fabio@cusp.ai>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7193 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 931 931
Lines 58188 58200 +12
=======================================
+ Hits 33146 33153 +7
- Misses 22001 22003 +2
- Partials 3041 3044 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EngHabu
reviewed
Apr 10, 2026
| OccurredAt: &occurredAt, | ||
| } | ||
|
|
||
| taskTemplate, err := pluginContext.TaskReader().Read(ctx) |
Contributor
There was a problem hiding this comment.
This may be an s3 hit if I recall.. do we want to do that every time?
Member
There was a problem hiding this comment.
I think it's okay for now since we already do that for PythonFunctionTask. We can have a separate PR to do it.
Member
Author
EngHabu
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Dynamic log links currently work for the pod plugin (normal
PythonFunctionTask) and for the kubeflow plugin. Currently they cannot be toggled for Ray, Dask or Spark tasks. This PR fixes this.What changes were proposed in this pull request?
The so-called
TaskTemplatethat contains the dynamic log link config needs to be included in thetasklog.Input{...}based on which the log links are generated.How was this patch tested?
Added unit tests.
Check all the applicable boxes