Add cluster service and SelectCluster method#7187
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
EngHabu
reviewed
Apr 9, 2026
flyteidl2/cluster/service.proto
Outdated
Comment on lines
+12
to
+15
| option (google.api.http) = { | ||
| post: "/cluster/api/v1/select" | ||
| body: "*" | ||
| }; |
Contributor
There was a problem hiding this comment.
No google/api annotations needed.. we don't use gateway anymore
| sc.Mux.Handle(path, handler) | ||
| logger.Infof(ctx, "Mounted DataProxyService at %s", path) | ||
|
|
||
| clusterSvc := service.NewClusterService(baseURL) |
Contributor
There was a problem hiding this comment.
Does this have dns:/// prefix? http://? does it matter?
Contributor
Author
There was a problem hiding this comment.
http but i was thinking clients can normalize it as they please? can also switch to dns if you think that makes more sense!
$ curl -s -X POST http://localhost:30080/flyteidl2.cluster.ClusterService/SelectCluster \
-H "Content-Type: application/json" \
-d '{"resource": {"orgId": {"name": "test"}}, "operation": "OPERATION_CREATE_UPLOAD_LOCATION"}'
{"clusterEndpoint":"http://localhost:8090"}
Contributor
There was a problem hiding this comment.
We expect clients to be using connect, in which case I think http works?
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
EngHabu
approved these changes
Apr 10, 2026
| sc.Mux.Handle(path, handler) | ||
| logger.Infof(ctx, "Mounted DataProxyService at %s", path) | ||
|
|
||
| clusterSvc := service.NewClusterService(baseURL) |
Contributor
There was a problem hiding this comment.
We expect clients to be using connect, in which case I think http works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stub implementation in Dataproxy
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main