Move GetActionData from RunsService to Dataproxy#7184
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Apr 10, 2026
| return fmt.Errorf("failed to run migrations: %w", err) | ||
| } | ||
| //go:embed sql/*.sql | ||
| var migrationFS embed.FS |
Member
There was a problem hiding this comment.
Thanks, I think my Claude forgot to remove it, sorry
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Apr 10, 2026
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also introduce new GetActionDataURIs in run service.
Why are the changes needed?
Required for secure environments to limit dataflow
How was this patch tested?
Ran the flyte demo cluster locally. Verified I could launch a run and see the inputs and outputs in the UI still.
Verified the new endpoint worked with SDK changes that call dataproxy.GetActionDetails
Without sdk changes
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main