Skip to content

Move GetActionData from RunsService to Dataproxy#7184

Merged
katrogan merged 12 commits intov2from
katrina/eng26-349-move-getactiondata-to-dataproxy-v2
Apr 13, 2026
Merged

Move GetActionData from RunsService to Dataproxy#7184
katrogan merged 12 commits intov2from
katrina/eng26-349-move-getactiondata-to-dataproxy-v2

Conversation

@katrogan
Copy link
Copy Markdown
Contributor

@katrogan katrogan commented Apr 9, 2026

Also introduce new GetActionDataURIs in run service.

Why are the changes needed?

Required for secure environments to limit dataflow

How was this patch tested?

Ran the flyte demo cluster locally. Verified I could launch a run and see the inputs and outputs in the UI still.

Verified the new endpoint worked with SDK changes that call dataproxy.GetActionDetails

.venv/bin/python -c "
  import asyncio, flyte
  from flyte.remote._run import Run

  async def main():
      await flyte.init_from_config.aio('.flyte/config-oss-local.yaml', project='flytesnacks', domain='development')
      run = await Run.get.aio('rjwnhmwkflr7dcr6k4rf')
      print('Run:', run.name)
      print('Phase:', run.phase)
      inputs = await run.inputs.aio()
      print('Inputs:', inputs)
      outputs = await run.outputs.aio()
      print('Outputs:', outputs)

  asyncio.run(main())
  "

  Output:
  Run: rjwnhmwkflr7dcr6k4rf
  Phase: ActionPhase.SUCCEEDED
  Inputs: {'x': 4}
  Outputs: ActionOutputs(o0=13)

Without sdk changes

.venv/bin/python -c "
  import asyncio, flyte
  from flyte._initialize import get_client
  from flyteidl2.dataproxy import dataproxy_service_pb2
  from flyteidl2.common import identifier_pb2

  async def main():
      await flyte.init_from_config.aio('.flyte/config-oss-local.yaml', project='flytesnacks', domain='development')
      resp = await get_client().dataproxy_service.get_action_data(
          dataproxy_service_pb2.GetActionDataRequest(
              action_id=identifier_pb2.ActionIdentifier(
                  run=identifier_pb2.RunIdentifier(
                      name='rjwnhmwkflr7dcr6k4rf',
                      project='flytesnacks',
                      domain='development',
                      org='testorg',
                  ),
                  name='a0',
              )
          )
      )
      print('Inputs:', resp.inputs)
      print('Outputs:', resp.outputs)

  asyncio.run(main())
  "

  Output:
  Inputs: literals {
    name: "x"
    value {
      scalar {
        primitive {
          integer: 4
        }
      }
    }
  }

  Outputs: literals {
    name: "o0"
    value {
      scalar {
        primitive {
          integer: 13
        }
      }
    }
  }

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

  • main
    • Flyte 2 #6583
      • Move GetActionData from RunsService to Dataproxy 👈

katrogan added 4 commits April 9, 2026 15:37
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
katrogan added 3 commits April 9, 2026 18:19
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
return fmt.Errorf("failed to run migrations: %w", err)
}
//go:embed sql/*.sql
var migrationFS embed.FS
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think my Claude forgot to remove it, sorry

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@pingsutw pingsutw self-assigned this Apr 10, 2026
@pingsutw pingsutw added this to the V2 GA milestone Apr 10, 2026
@pingsutw pingsutw assigned katrogan and unassigned pingsutw Apr 10, 2026
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan katrogan merged commit 625e53e into v2 Apr 13, 2026
21 checks passed
@katrogan katrogan deleted the katrina/eng26-349-move-getactiondata-to-dataproxy-v2 branch April 13, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants