Conversation
…ames - Rename chart directory and all references from flyte-sandbox to flyte-demo - Add fullnameOverride for subcharts to remove release name prefix from pods: - docker-registry, minio, postgresql get clean names - flyte-binary gets fullnameOverride: flyte-binary - Console deployment/service hardcoded to flyte-console - Rename Docker image from flyte-sandbox-v2 to flyte-demo - Rename bootstrap binary from flyte-sandbox-bootstrap to flyte-demo-bootstrap - Update all kustomize, workflow, and config references Signed-off-by: Kevin Su <pingsutw@apache.org>
The ingress template was calling flyte-binary.fullname from the parent chart's context, which resolved to flyte-demo instead of flyte-binary. Read fullnameOverride directly from the subchart's values instead. Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
commented
Apr 9, 2026
machichima
reviewed
Apr 9, 2026
Signed-off-by: Kevin Su <pingsutw@apache.org>
machichima
reviewed
Apr 9, 2026
machichima
reviewed
Apr 9, 2026
| {{- $backendService := "" }} | ||
| {{- if index .Values "flyte-binary" "enabled" }} | ||
| {{- $backendService = include "flyte-binary.service.http.name" . }} | ||
| {{- $backendService = printf "%s-http" ( index .Values "flyte-binary" "fullnameOverride" | default "flyte-binary" ) }} |
Member
There was a problem hiding this comment.
Why can't we use include "flyte-binary.service.http.name" here?
Member
Author
There was a problem hiding this comment.
Because i use fullNameOverride here. (To override the minio and console pod name. flyte-sandbox-minio-* -> minio)
https://github.com/flyteorg/flyte/pull/7170/files#diff-adef5e315f572e8907dfd23161687da28a891638e72eea0f874c0c134b2f9c23R16-R19
This was changed as part of the rename from flyte-sandbox → flyte-demo. The old version
used the helper template flyte-binary.service.http.name (defined in the flyte-binary
subchart) to derive the backend service name. The new version constructs the service name
directly using fullnameOverride from values, appending -http.
The reason: when the chart was renamed from flyte-sandbox to flyte-demo, the template
helper flyte-binary.service.http.name may not resolve correctly across the chart rename
(since Helm template includes depend on chart naming context). By inlining the service
name construction with printf "%s-http" using the fullnameOverride value, it becomes
independent of the subchart's internal template names — making it more robust during the
rename.
Member
There was a problem hiding this comment.
I think we can still use it as we only rename the parent chart (flyte-sandbox -> flyte-demo) while keeping the subchart flyte-binary the same?
Member
Author
There was a problem hiding this comment.
no, it doesn't work because I override the pods name to flyte-binary, so the service name is flyte-binary-http as well, not flyte-demo-http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flyte-sandboxHelm chart toflyte-demofullnameOverridefor all subcharts to give pods clean names without release prefix:flyte-sandbox-docker-registry-*docker-registry-*flyte-sandbox-<hash>(flyte-binary)flyte-binary-*flyte-sandbox-console-*flyte-console-*flyte-sandbox-minio-*minio-*flyte-sandbox-postgresql-*postgresql-*flyte-sandbox-v2toflyte-demoTest plan
make manifestsindocker/sandbox-bundled/regenerates manifests cleanlymake buildindocker/sandbox-bundled/builds the sandbox imagemake startboots the sandbox and all pods have the expected nameskubectl get pods -n flyteshows clean pod namesmain