flytestdlib: add additional storage cache metrics and implement freecache prom collector#7115
Open
xjerod wants to merge 1 commit intoflyteorg:masterfrom
Open
Conversation
xjerod
force-pushed
the
union/upstream-1eb60aa132ca9b75891a9143059929632ce9c860
branch
from
9f43cdd to
49d2c17
Compare
…ache prom collector (flyteorg#937) Adds Prometheus metrics to `flytestdlib/storage` to help identify Flytepropeller memory consumption from the in-memory data cache and large inputs/outputs — the two main controllable sources of propeller OOM pressure. - **`rawstores.go`**: Scopes the `cache`, `proto`, and `stow` metric groups into named sub-scopes so their metrics are easier to distinguish in dashboards. - **`protobuf_store.go`**: Adds `read_bytes_total` and `written_bytes_total` counters to track byte volume moving through the protobuf store, surfacing executions that pass large data between tasks. - **`cached_rawstore.go`**: Implements the freecache `prometheus.Collector` (resolving a long-standing TODO), exposing snapshot metrics scraped each Prometheus interval: - `entry_count` (gauge) — current occupancy of the in-memory cache - `evacuate_count_total` — evictions due to memory pressure; the primary signal that the cache is sized too small relative to workload - `overwrite_count_total` / `expired_count_total` — entry churn Also adds `cache_read_bytes_total` and `cache_write_bytes_total` counters to track cache throughput. Signed-off-by: Jerod <jerod@union.ai>
xjerod
force-pushed
the
union/upstream-1eb60aa132ca9b75891a9143059929632ce9c860
branch
from
49d2c17 to
983a2a4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7115 +/- ##
==========================================
+ Coverage 56.94% 56.96% +0.02%
==========================================
Files 931 931
Lines 58188 58219 +31
==========================================
+ Hits 33135 33165 +30
Misses 22011 22011
- Partials 3042 3043 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Prometheus metrics to
flytestdlib/storageto help identify Flytepropeller memory consumption from the in-memory data cache and large inputs/outputs — the two main controllable sources of propeller OOM pressure.rawstores.go: Scopes thecache,proto, andstowmetric groups into named sub-scopes so their metrics are easier to distinguish in dashboards.protobuf_store.go: Addsread_bytes_totalandwritten_bytes_totalcounters to track byte volume moving through the protobuf store, surfacing executions that pass large data between tasks.cached_rawstore.go: Implements the freecacheprometheus.Collector(resolving a long-standing TODO), exposing snapshot metrics scraped each Prometheus interval:entry_count(gauge) — current occupancy of the in-memory cacheevacuate_count_total— evictions due to memory pressure; the primary signal that the cache is sized too small relative to workloadoverwrite_count_total/expired_count_total— entry churnAlso adds
cache_read_bytes_totalandcache_write_bytes_totalcounters to track cache throughput.