Fix moved flow relative import resolution#259
Open
abisheik687 wants to merge 1 commit intoflydelabs:mainfrom
Open
Fix moved flow relative import resolution#259abisheik687 wants to merge 1 commit intoflydelabs:mainfrom
abisheik687 wants to merge 1 commit intoflydelabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes moved
.flydeimports resolving their own relative dependencies from the wrong directory.When a root flow imports a visual flow from another folder, that imported visual flow can also import local files next to itself. Before this change, those nested imports were still resolved relative to the root flow path, so moving files could break otherwise valid local imports.
Changes
Root.flydeimportsmoved/Wrapper.flyde, andWrapper.flydeimports siblingAddOne.flyde.js.loader/fixturefrom source-based test execution.Verification
Ran locally:
Results:
I also ran the full loader suite locally. Most tests passed, but this Windows setup is missing generated
@flyde/nodesbundled-config UI assets (CodeExpression.js,Switch.js) because the full workspace build scripts are Unix-oriented and require the node UI bundle generation path. The failures were unrelated to this resolver change; the targeted resolver checks above passed.Demo
Demo video: https://github.com/abisheik687/flyde/releases/download/flyde-moved-imports-demo/demo-flyde-moved-imports.mp4
Fixes #112