Skip to content

Clarify Doctor readiness states - #46

Merged
fly1d merged 1 commit into
mainfrom
codex/clarify-doctor-readiness
Sep 11, 2026
Merged

fly1d merged 1 commit into
mainfrom
codex/clarify-doctor-readiness

Conversation

@fly1d

@fly1d fly1d commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Decision

Doctor should say that a failure is ready to reduce only after its fresh-copy baseline passes. A successful scan without a command is useful preflight evidence, but it is not reproduction evidence.

Context

repomin doctor SOURCE previously mapped every result with no failed checks to ready, even when baseline.status was not_run. That can send a first-time user into reduction before they have configured or verified the target failure.

Changes

  • text output distinguishes static checks passed; failure not verified, ready to reduce, and needs attention;
  • Markdown uses static_checks_passed, ready_to_reduce, or needs_attention;
  • next-step guidance follows the overall readiness, so a passing baseline cannot hide another failed check;
  • the Doctor guide and changelog document the distinction and Markdown value change.

Verification

  • python -m unittest tests.test_doctor -v (44 passed)
  • python scripts/check_contribution.py --skip-tests
  • complete local suite before the final narrow review correction (767 passed, 4 skipped)
  • offline benchmark suite (16 passed)
  • manual CLI checks for static-only and 2/2 passing-baseline output

GitHub CI will run the complete suite on this exact commit.

@fly1d
fly1d merged commit 5a1cd35 into main Sep 11, 2026
10 checks passed
@fly1d
fly1d deleted the codex/clarify-doctor-readiness branch September 11, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant