Clarify Doctor readiness states - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Doctor should say that a failure is ready to reduce only after its fresh-copy baseline passes. A successful scan without a command is useful preflight evidence, but it is not reproduction evidence.
Context
repomin doctor SOURCEpreviously mapped every result with no failed checks toready, even whenbaseline.statuswasnot_run. That can send a first-time user into reduction before they have configured or verified the target failure.Changes
static checks passed; failure not verified,ready to reduce, andneeds attention;static_checks_passed,ready_to_reduce, orneeds_attention;Verification
python -m unittest tests.test_doctor -v(44 passed)python scripts/check_contribution.py --skip-testsGitHub CI will run the complete suite on this exact commit.