Skip to content

Check renderer #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grbagwe wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Check renderer #1063

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
442ab44
env requirement update remove redis version
grbagwe May 5, 2022
fef789c
pyglet renderer bug removed
grbagwe May 5, 2022
42cae88
pyglet renderer bug removed
grbagwe May 5, 2022
7c0bb23
pyglet renderer bug removed
grbagwe May 5, 2022
0fb96d1
virtual environment update
grbagwe May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ dependencies:
- psutil
- opencv-python
- boto3==1.10.45
- redis~=2.10.6
- redis
4 changes: 2 additions & 2 deletions flow/envs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def __init__(self,
self.sim_params = deepcopy(sim_params)
# check whether we should be rendering
self.should_render = self.sim_params.render
self.sim_params.render = False
self.sim_params.render = self.sim_params.render
Copy link
Copy Markdown
Member

@eugenevinitsky eugenevinitsky May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unnecessary?

time_stamp = ''.join(str(time.time()).split('.'))
if os.environ.get("TEST_FLAG", 0):
# 1.0 works with stress_test_start 10k times
Expand Down Expand Up @@ -434,7 +434,7 @@ def reset(self):
# Now that we've passed the possibly fake init steps some rl libraries
# do, we can feel free to actually render things
if self.should_render:
self.sim_params.render = True
self.sim_params.render = self.should_render
# got to restart the simulation to make it actually display anything
self.restart_simulation(self.sim_params)

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ setproctitle
psutil
opencv-python
boto3==1.10.45
redis~=2.10.6
redis
pandas==0.24.2
plotly==2.4.0
tabulate
Expand Down
22 changes: 17 additions & 5 deletions tutorials/tutorial00_flow.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
"cells": [
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"# Tutorial 0: Flow\n",
"\n",
Expand All @@ -13,7 +17,11 @@
},
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"## 1. High-level of Flow\n",
"\n",
Expand Down Expand Up @@ -55,7 +63,11 @@
},
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"pycharm": {
"name": "#%% md\n"
}
},
"source": [
"## 2. Codebase structure\n",
"\n",
Expand Down Expand Up @@ -96,7 +108,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand All @@ -110,7 +122,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.6.8"
"version": "3.7.3"
}
},
"nbformat": 4,
Expand Down
Loading