Repository navigation
fix(flipt-v2): indent volumeClaimTemplates labels and annotations - #303
Merged
kodiakhq[bot] merged 1 commit intoOct 5, 2026
Merged
Conversation
With `kind: StatefulSet` and `persistence.enabled`, `persistence.labels` and `persistence.annotations` were rendered at the same indentation as their `labels:` / `annotations:` keys, so they became sibling fields of `metadata` and the API server rejected the StatefulSet with `strict decoding error: unknown field "spec.volumeClaimTemplates[0].metadata.<key>"`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Johan Brodin <johan.brodin@gmail.com>
erka
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
kind: StatefulSetandpersistence.enabled, settingpersistence.labelsorpersistence.annotationsmakes the StatefulSet unrenderable for the API server. The template indents their contents at the same level as thelabels:/annotations:keys:so the keys become siblings of
metadata, and the apply fails:This moves both to
nindent 10. Rendered withkind: StatefulSet,persistence.enabled: trueand a label and annotation set, the StatefulSet now passes a server-side dry run on GKE 1.35; before the change the same values were rejected as above. The Deployment path and the standalone PVC template are unchanged.Chart version is bumped to 2.13.2.