Skip to content

Remove unnecessary scroll assertions #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amantoux merged 2 commits into from
Sep 20, 2025
Merged

Remove unnecessary scroll assertions #552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa8f90
Adapt scroll assertions to case where `scrollable=false`
amantoux Sep 20, 2025
147f4d2
Remove unnecessary assertions
amantoux Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions packages/fleather/lib/src/widgets/editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,21 +1627,6 @@ class RawEditorState extends EditorState
bool _showCaretOnScreenScheduled = false;

void _showCaretOnScreen([bool withAnimation = true]) {
assert(
widget.enableInteractiveSelection
? _scrollController.positions.isNotEmpty
: true,
'ScrollController not attached to any scroll views. '
'When editor configured with scrollable = false and '
'enableInteractiveSelection = true, make sure the editor is the child '
'of a Scrollable widget.');
assert(
widget.showCursor ? _scrollController.positions.isNotEmpty : true,
'ScrollController not attached to any scroll views. '
'When editor configured with scrollable = false and '
'showCursor = true, make sure the editor is the child '
'of a Scrollable widget.');

if (!widget.showCursor ||
!widget.enableInteractiveSelection ||
_showCaretOnScreenScheduled) {
Expand Down