Skip to content

fix: ClickHouse backup drain loop — batch merging and bug fixes #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsodre wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix: ClickHouse backup drain loop — batch merging and bug fixes #907

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40ce046
fix: ClickHouse backup drain loop — batch merging, continuous drain, …
fsodre Mar 23, 2026
42a3448
fix: replace read-only disk retrieve with atomic take_oldest
fsodre Mar 23, 2026
ba59f58
test: fill coverage gaps for disk backup and outage scenarios
fsodre Mar 24, 2026
8aafcc2
fix: address review feedback — end() flushes last_cached, reduce lock…
fsodre Mar 24, 2026
ae5ecd0
fix: end() disk save should only run when CH commit fails
fsodre Mar 24, 2026
3ed2bde
fix: address remaining review nits
fsodre Mar 24, 2026
ebf72d1
fix: disk key collisions, mock server robustness, rustfmt
fsodre Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rbuilder-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ serde_json.workspace = true
# alloy
alloy-primitives.workspace = true

strum = "0.27"
strum = { version = "0.27", features = ["derive"] }
tokio = { version = "1.40.0", default-features = false, features = [
"sync",
"time",
Expand Down
Loading
Loading