per-crate versions#536
Merged
zeroXbrock merged 7 commits intomainfrom May 2, 2026
Merged
Conversation
- TODO: update versions to reflect breaking changes & patches - require other crates by version, not path (see workspace manifest)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Each crate was deriving its version from the workspace, but crates have their own dependency graphs and locally- (or downstream)-breaking changes that may not reflect the CLI (the binary release).
Making a breaking change in contender_core doesn't mean that the cli has a breaking change. To the cli, that's a patch.
for example: the current unreleased set of changes includes one breaking feature in
contender_core, but it doesn't actually affect the code incontender_cli. Socontender_coreshould switch tov0.11.0andcontender_cli(because it relies oncontender_corebut doesn't introduce any breaking changes to its users) should switch tov0.10.1(which will happen in a PR following this one).Solution
version.workspace = truePR Checklist
cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked --fixcargo fmt --allCHANGELOG.mdin each affected crate