fix(fassets): RedemptionPerformed requestId is uint256, not uint64 - #1455
Open
Pratiikpy wants to merge 1 commit into
Open
fix(fassets): RedemptionPerformed requestId is uint256, not uint64#1455Pratiikpy wants to merge 1 commit into
Pratiikpy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RedemptionPerformedis documented withuint64 indexed requestId. The deployed contract declaresuint256.Why it matters
requestIdis an indexed parameter, so its type is part of the event signature and therefore part oftopic0:topic0RedemptionPerformed(address,address,uint64,bytes32,uint256,int256)0x80b49fdd7580ee833ccd36349a80427cff16f09d4520f8a2b49983e6b106b5daRedemptionPerformed(address,address,uint256,bytes32,uint256,int256)0xd5150395b21c5be6cbb37ea167761efe7a013baccbd1bb7e5922fa261ccc3331These are different topics. An indexer written faithfully from this page subscribes to the first one and matches nothing — so every redemption looks permanently open and no completion is ever recorded. It fails silently, which is the worst way for it to fail: there is no error to debug, just an empty result set that looks like "no redemptions completed yet".
I hit this building a redemption monitor and lost a while assuming my filter was wrong before checking the source.
Source of truth
contracts/userInterfaces/IAssetManagerEvents.sol:Scope
One line. I diffed every event signature on this page against
IAssetManagerEvents.soland this is the only type mismatch among the 25 documented events — the rest match exactly.