Skip to content

feat(publisher): Introduce V1_1 for MexicoNewsDaily - #970

Open
addie9800 wants to merge 2 commits into
masterfrom
update-mexico-news-daily
Open

feat(publisher): Introduce V1_1 for MexicoNewsDaily#970
addie9800 wants to merge 2 commits into
masterfrom
update-mexico-news-daily

Conversation

@addie9800

Copy link
Copy Markdown
Collaborator

No description provided.

@MaxDall MaxDall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUEST_CHANGES — the new V1_1 carries V1's p[text()] predicate over, and it silently drops <em>-wrapped article prose.

mx.MexicoNewsDaily: read 10 of 100 scanned (6 flagged, 6 in draw); static read (VALID_UNTIL, version scope, image caption/author/cover pairing), Tier-1 coherence and a structural sweep of all 10 checked. 1 blocker inline.
Not inline:

  • Nit — the whole 100-article draw came out of the 2018 end of post-sitemap (all ten cached articles publish May–Jun 2018), so neither this review nor the new MexicoNewsDaily_2026_08_18 fixture — itself a 2018 article — exercises a current, possibly paywalled page. Sitemap(..., reverse=True) in mx/__init__.py would make crawls start from the newest posts and keep future reviews on the live layout.

)

class V1_1(V1):
_paragraph_selector = XPath("//div[@class='tts_content_wrapper_1']/p[text()]")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker — p[text()] drops any <p> whose text sits inside <em>/<a>, so real prose is lost. “…UPDATE June 20, 4:16pm CDT: FIFA announced a fine of 10,000 Swiss francs (US $10,000) against the Mexican Football Federation…” never reaches the body [1]; a CORRECTION: paragraph goes the same way [2], and all 100 pooled articles show an uncaptured <p> (mostly the Source: … trailer). Fix: /p[normalize-space()], plus a bloat filter for the Source:/subscribe trailers, which would otherwise leak in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants