Skip to content

feat: add support for mathjs AST#654

Merged
fkling merged 1 commit intofkling:masterfrom
goodproblems:master
Jul 2, 2022
Merged

feat: add support for mathjs AST#654
fkling merged 1 commit intofkling:masterfrom
goodproblems:master

Conversation

@mattvague
Copy link
Copy Markdown
Contributor

Adds support for ASTs generated by http://mathjs.org

@mattvague mattvague changed the title Add support for mathjs AST feat: add support for mathjs AST Jun 13, 2022
@fkling fkling merged commit 2ea36e9 into fkling:master Jul 2, 2022
@fkling
Copy link
Copy Markdown
Owner

fkling commented Jul 2, 2022

Nice! It doesn't look like the AST contains positioning information, so it can't be corrolated with the source code. It would be nice if this supported or enabled eventually.

@fkling fkling added the deployed to production Marks issues/PRs that are deployed to https://astexplorer.net label Jul 2, 2022
@mattvague
Copy link
Copy Markdown
Contributor Author

@fkling Sweet, thanks! I've started on a PR adding positional information to the AST here but will need some help from the lib author. Will create a new PR here to add support once that's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed to production Marks issues/PRs that are deployed to https://astexplorer.net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants