Experiment with a command-line tool for querying profile contents#5663
Draft
mstange wants to merge 54 commits intofirefox-devtools:mainfrom
Draft
Experiment with a command-line tool for querying profile contents#5663mstange wants to merge 54 commits intofirefox-devtools:mainfrom
mstange wants to merge 54 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5663 +/- ##
==========================================
- Coverage 85.37% 84.27% -1.11%
==========================================
Files 322 330 +8
Lines 32069 34453 +2384
Branches 8814 9487 +673
==========================================
+ Hits 27378 29034 +1656
- Misses 4260 4990 +730
+ Partials 431 429 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
force-pushed
the
pq-cli-wip
branch
5 times, most recently
from
288f7da to
c87bd3c
Compare
canova
force-pushed
the
pq-cli-wip
branch
11 times, most recently
from
aa045b3 to
cdb3e0c
Compare
This is useful for cases where I want to drop all the "idle" category samples, so I can focus on non-idle samples. Or it can be useful for dropping the whole profiler overhead by removing the "profiler" category. I would like to use this transform in the pq cli tool, so we can remove the idle category before finding the "top functions". Otherwise the idle category just pollutes the output of the cli a lot.
A `yarn test:cli` script was added to run only the cli tests, but it looks like the main tests are also running them since they match the testMatch glob.
This gives much better defaults for a cli, and has much better ergonomics. For example, we didn't have per-command help, and commander handles it out of the box. Also we don't have to parse all the cli arguments one by one, commander takes care of them for us. Overall it makes adding a new command and updating them easier.
I've tried to use and love the profiler-cli in the terminal, but it's just so difficult to type compared to pq, and it made me so annoyed. I think it makes sense to publish the package as profiler-cli, but this pq symlink as a shortcut is such a huge productivity boost if you are actually using the tool yourself.
Denis' tool has this feature already. It's good if we support it too since the logs are important for some teams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I've wanted to inspect profiles from the command line, without loading them in the web UI.
Here's an experiment I've been working on, which creates a
pqtool ("profile query"). To test, clone this branch and runyarn build-profile-query-cli- this creates a./dist/pq.jsartifact. Then somehow make it accessible via your path, for example by putting a shell script with the contentsnode ~/code/profiler/src/profile-query-cli/dist/pq.js "$@"into abindirectory in your path.Or you can run
yarn linkin./profile-query-cli/to linkpqglobally.pq load 'https://share.firefox.dev/hash'orpq load profile.json.gzstart a session.