Clean up 'any' typing in src/emulators

src/emulator/adminSdkConfig.ts

@@ -43,7 +43,7 @@ export async function getProjectAdminSdkConfigOrCached(
     const config = await getProjectAdminSdkConfig(projectId);
     setCacheAdminSdkConfig(projectId, config);
     return config;
-  } catch (e: any) {
+  } catch (e: unknown) {
     logger.debug(`Failed to get Admin SDK config for ${projectId}, falling back to cache`, e);
     return getCachedAdminSdkConfig(projectId);
   }
@@ -71,11 +71,11 @@ async function getProjectAdminSdkConfig(projectId: string): Promise<AdminSdkConf
   try {
     const res = await apiClient.get<AdminSdkConfig>(`projects/${projectId}/adminSdkConfig`);
     return res.body;
-  } catch (err: any) {
+  } catch (err: unknown) {
     throw new FirebaseError(
       `Failed to get Admin SDK for Firebase project ${projectId}. ` +
         "Please make sure the project exists and your account has permission to access it.",
-      { exit: 2, original: err },
+      { exit: 2, original: err instanceof Error ? err : new Error(String(err)) },
     );
   }
 }

src/emulator/auth/operations.ts

@@ -1642,7 +1642,7 @@ async function signInWithIdp(
         userMatchingProvider,
       ));
     }
-  } catch (err: any) {
+  } catch (err: unknown) {
     if (reqBody.returnIdpCredential && err instanceof BadRequestError) {
       response.errorMessage = err.message;
       return response;

src/emulator/commandUtils.ts

@@ -172,8 +172,8 @@ export async function beforeEmulatorCommand(options: any): Promise<any> {
   ) {
     try {
       await requireAuth(options);
-    } catch (e: any) {
-      logger.debug(e);
+    } catch (e: unknown) {
+      logger.debug(e as any);
       utils.logLabeledWarning(
         "emulators",
         `You are not currently authenticated so some features may not work correctly. Please run ${clc.bold(
@@ -333,8 +333,8 @@ function processKillSignal(
         }
       }
       res();
-    } catch (e: any) {
-      logger.debug(e);
+    } catch (e: unknown) {
+      logger.debug(e as any);
       rej();
     }
   };
@@ -512,9 +512,11 @@ export async function checkJavaMajorVersion(): Promise<number> {
           stdio: ["inherit", "pipe", "pipe"],
         },
       );
-    } catch (err: any) {
+    } catch (err: unknown) {
       return reject(
-        new FirebaseError(`Could not spawn \`java -version\`. ${JAVA_HINT}`, { original: err }),
+        new FirebaseError(`Could not spawn \`java -version\`. ${JAVA_HINT}`, {
+          original: err instanceof Error ? err : new Error(String(err)),
+        }),
       );
     }
 

src/emulator/controller.ts

@@ -174,11 +174,12 @@ export function shouldStart(options: Options, name: Emulators): boolean {
     try {
       normalizeAndValidate(options.config.src.functions);
       return true;
-    } catch (err: any) {
+    } catch (err: unknown) {
+      const message = err instanceof Error ? err.message : String(err);
       EmulatorLogger.forEmulator(Emulators.FUNCTIONS).logLabeled(
         "ERROR",
         "functions",
-        `Failed to start Functions emulator: ${err.message}`,
+        `Failed to start Functions emulator: ${message}`,
       );
       return false;
     }
@@ -357,7 +358,7 @@ export async function startAll(
     if (!isDemoProject) {
       try {
         projectNumber = await needProjectNumber(options);
-      } catch (err: any) {
+      } catch (err: unknown) {
         EmulatorLogger.forEmulator(Emulators.EXTENSIONS).logLabeled(
           "ERROR",
           Emulators.EXTENSIONS,
@@ -781,11 +782,9 @@ export async function startAll(
       if (!options.instance) {
         options.instance = await getDefaultDatabaseInstance(projectId);
       }
-    } catch (e: any) {
-      databaseLogger.log(
-        "DEBUG",
-        `Failed to retrieve default database instance: ${JSON.stringify(e)}`,
-      );
+    } catch (e: unknown) {
+      const message = e instanceof Error ? e.message : String(e);
+      databaseLogger.log("DEBUG", `Failed to retrieve default database instance: ${message}`);
     }
 
     const rc = dbRulesConfig.normalizeRulesConfig(
@@ -1117,7 +1116,7 @@ export async function exportEmulatorData(exportPath: string, options: any, initi
   let origin;
   try {
     origin = await hubClient.getStatus();
-  } catch (e: any) {
+  } catch (e: unknown) {
     const filePath = EmulatorHub.getLocatorFilePath(projectId);
     throw new FirebaseError(
       `The emulator hub for ${projectId} did not respond to a status check. If this error continues try shutting down all running emulators and deleting the file ${filePath}`,
@@ -1161,10 +1160,10 @@ export async function exportEmulatorData(exportPath: string, options: any, initi
   try {
     const targets = filterEmulatorTargets(options);
     await hubClient.postExport({ path: exportAbsPath, initiatedBy, targets });
-  } catch (e: any) {
+  } catch (e: unknown) {
     throw new FirebaseError("Export request failed, see emulator logs for more information.", {
       exit: 1,
-      original: e,
+      original: e instanceof Error ? e : new Error(String(e)),
     });
   }
 

src/emulator/dataconnectEmulator.ts

@@ -95,8 +95,9 @@ export class DataConnectEmulator implements EmulatorInstance {
           );
         }
       }
-    } catch (err: any) {
-      this.logger.log("DEBUG", `'fdc build' failed with error: ${err.message}`);
+    } catch (err: unknown) {
+      const message = err instanceof Error ? err.message : String(err);
+      this.logger.log("DEBUG", `'fdc build' failed with error: ${message}`);
     }
     const env = await DataConnectEmulator.getEnv(this.args.account, this.args.extraEnv);
     await start(
@@ -259,8 +260,8 @@ export class DataConnectEmulator implements EmulatorInstance {
           // Handle errors like command not found
           reject(err);
         });
-      } catch (e: any) {
-        if (isIncomaptibleArchError(e)) {
+      } catch (e: unknown) {
+        if (isIncomaptibleArchError(e as Error)) {
           reject(
             new FirebaseError(
               `Unknown system error when running the SQL Connect toolkit. ` +
@@ -343,14 +344,14 @@ export class DataConnectEmulator implements EmulatorInstance {
           `Successfully connected to ${connectionString}}`,
         );
         return true;
-      } catch (err: any) {
+      } catch (err: unknown) {
         if (i === MAX_RETRIES) {
           throw err;
         }
         this.logger.logLabeled(
           "DEBUG",
           "SQL Connect",
-          `Retrying connectToPostgress call (${i} of ${MAX_RETRIES} attempts): ${err}`,
+          `Retrying connectToPostgress call (${i} of ${MAX_RETRIES} attempts): ${String(err)}`,
         );
         await new Promise((resolve) => setTimeout(resolve, 2000));
       }
@@ -413,9 +414,13 @@ export class DataConnectEmulatorClient {
         body,
       );
       return res;
-    } catch (err: any) {
-      if (err.status === 500) {
-        throw new FirebaseError(`SQL Connect emulator: ${err?.context?.body?.message}`);
+    } catch (err: unknown) {
+      if (typeof err === "object" && err !== null && "status" in err) {
+        const status = (err as { status: unknown }).status;
+        if (status === 500) {
+          const message = (err as any)?.context?.body?.message;
+          throw new FirebaseError(`SQL Connect emulator: ${message || String(err)}`);
+        }
       }
       throw err;
     }

src/emulator/download.ts

@@ -40,7 +40,7 @@ export async function downloadEmulator(name: DownloadableEmulators): Promise<voi
   let tmpfile: string;
   try {
     tmpfile = await downloadUtils.downloadToTmp(emulator.opts.remoteUrl, !!emulator.opts.auth);
-  } catch (err: any) {
+  } catch (err: unknown) {
     if (overrideVersion && err instanceof FirebaseError && err.status === 404) {
       throw new FirebaseError(
         `env variable ${name.toUpperCase()}_EMULATOR_VERSION set to ${overrideVersion}, 

src/emulator/functionsEmulator.ts

@@ -866,10 +866,11 @@ export class FunctionsEmulator implements EmulatorInstance {
         );
         try {
           await this.startRuntime(emulatableBackend);
-        } catch (e: any) {
+        } catch (e: unknown) {
+          const message = e instanceof Error ? e.message : String(e);
           this.logger.logLabeled(
             "ERROR",
-            `Failed to start functions in ${emulatableBackend.functionsDir}: ${e}`,
+            `Failed to start functions in ${emulatableBackend.functionsDir}: ${message}`,
           );
         }
       }
@@ -1172,8 +1173,8 @@ export class FunctionsEmulator implements EmulatorInstance {
     const client = EmulatorRegistry.client(Emulators.DATABASE);
     try {
       await client.post(apiPath, bundle, { headers: { Authorization: "Bearer owner" } });
-    } catch (err: any) {
-      this.logger.log("WARN", "Error adding Realtime Database function: " + err);
+    } catch (err: unknown) {
+      this.logger.log("WARN", "Error adding Realtime Database function: " + String(err));
       throw err;
     }
     return true;
@@ -1246,8 +1247,8 @@ export class FunctionsEmulator implements EmulatorInstance {
     const client = EmulatorRegistry.client(Emulators.FIRESTORE);
     try {
       signature === "cloudevent" ? await client.post(path, bundle) : await client.put(path, bundle);
-    } catch (err: any) {
-      this.logger.log("WARN", "Error adding firestore function: " + err);
+    } catch (err: unknown) {
+      this.logger.log("WARN", "Error adding firestore function: " + String(err));
       throw err;
     }
     return true;
@@ -1480,7 +1481,7 @@ export class FunctionsEmulator implements EmulatorInstance {
     if (functionsEnv.hasUserEnvs(projectInfo)) {
       try {
         return functionsEnv.loadUserEnvs(projectInfo);
-      } catch (e: any) {
+      } catch (e: unknown) {
         // Ignore - user envs are optional.
         logger.debug("Failed to load local environment variables", e);
       }
@@ -1578,13 +1579,17 @@ export class FunctionsEmulator implements EmulatorInstance {
     try {
       const data = fs.readFileSync(secretPath, "utf8");
       secretEnvs = functionsEnv.parseStrict(data);
-    } catch (e: any) {
-      if (e.code !== "ENOENT") {
-        this.logger.logLabeled(
-          "ERROR",
-          "functions",
-          `Failed to read local secrets file ${secretPath}: ${e.message}`,
-        );
+    } catch (e: unknown) {
+      if (typeof e === "object" && e !== null && "code" in e) {
+        const code = (e as { code: unknown }).code;
+        if (code !== "ENOENT") {
+          const message = e instanceof Error ? e.message : String(e);
+          this.logger.logLabeled(
+            "ERROR",
+            "functions",
+            `Failed to read local secrets file ${secretPath}: ${message}`,
+          );
+        }
       }
     }
     // Note - if trigger is undefined, we are loading in 'sequential' mode.
@@ -1945,11 +1950,12 @@ export class FunctionsEmulator implements EmulatorInstance {
     if (!pool.readyForWork(trigger.id, record.backend.runtime)) {
       try {
         await this.startRuntime(record.backend, trigger);
-      } catch (e: any) {
+      } catch (e: unknown) {
+        const message = e instanceof Error ? e.message : String(e);
         this.logger.logLabeled("ERROR", `Failed to handle request for function ${trigger.id}`);
         this.logger.logLabeled(
           "ERROR",
-          `Failed to start functions in ${record.backend.functionsDir}: ${e}`,
+          `Failed to start functions in ${record.backend.functionsDir}: ${message}`,
         );
         return;
       }

src/emulator/functionsEmulatorRuntime.ts

@@ -41,7 +41,7 @@
   return new Promise((res, rej) => {
     try {
       res(require(require.resolve(moduleName, opts))); // eslint-disable-line @typescript-eslint/no-var-requires
-    } catch (e: any) {
+    } catch (e: unknown) {
       rej(e);
     }
   });
@@ -51,7 +51,7 @@
   return new Promise((res, rej) => {
     try {
       res(require.resolve(moduleName, opts));
-    } catch (e: any) {
+    } catch (e: unknown) {
       rej(e);
     }
   });
@@ -289,7 +289,7 @@
       devDependencies: pkg.devDependencies || {},
     };
     return developerPkgJSON;
-  } catch (err: any) {
+  } catch (err: unknown) {
     return;
   }
 }
@@ -335,7 +335,7 @@
             try {
               new URL(arg);
               return arg;
-            } catch (err: any) {
+            } catch (err: unknown) {
               return;
             }
           } else if (typeof arg === "object") {
@@ -406,7 +406,7 @@
   let httpsProvider: any;
   try {
     httpsProvider = require(httpsProviderV1Resolution);
-  } catch (e: any) {
+  } catch (e: unknown) {
     httpsProvider = require(httpsProviderResolution);
   }
 
@@ -644,7 +644,7 @@
   let caughtErr;
   try {
     await func();
-  } catch (err: any) {
+  } catch (err: unknown) {
     caughtErr = err;
   }
   if (caughtErr) {
@@ -757,10 +757,15 @@
   let triggerModule;
   try {
     triggerModule = require(process.cwd());
-  } catch (err: any) {
-    if (err.code !== "ERR_REQUIRE_ESM") {
-      // Try to run diagnostics to see what could've gone wrong before rethrowing the error.
-      await moduleResolutionDetective(err);
+  } catch (err: unknown) {
+    if (typeof err === "object" && err !== null && "code" in err) {
+      const code = (err as { code: unknown }).code;
+      if (code !== "ERR_REQUIRE_ESM") {
+        // Try to run diagnostics to see what could've gone wrong before rethrowing the error.
+        await moduleResolutionDetective(err as unknown as Error);
+        throw err;
+      }
+    } else {
       throw err;
     }
     const modulePath = require.resolve(process.cwd());
@@ -780,7 +785,7 @@
   let debug: FunctionsRuntimeBundle["debug"];
   try {
     debug = JSON.parse(message) as FunctionsRuntimeBundle["debug"];
-  } catch (e: any) {
+  } catch (e: unknown) {
     new EmulatorLog("FATAL", "runtime-error", `Got unexpected message body: ${message}`).log();
     await flushAndExit(1);
     return;
@@ -819,11 +824,12 @@
   await initializeRuntime();
   try {
     functionModule = await loadTriggers();
-  } catch (e: any) {
+  } catch (e: unknown) {
+    const message = e instanceof Error ? e.message : String(e);
     new EmulatorLog(
       "FATAL",
       "runtime-status",
-      `Failed to initialize and load triggers. This shouldn't happen: ${e.message}`,
+      `Failed to initialize and load triggers. This shouldn't happen: ${message}`,
     ).log();
     await flushAndExit(1);
   }
@@ -889,9 +895,14 @@
         case "http":
           await runHTTPS(trigger, [req, res]);
       }
-    } catch (err: any) {
-      new EmulatorLog("FATAL", "runtime-error", err.stack ? err.stack : err).log();
-      res.status(500).send(err.message);
+    } catch (err: unknown) {
+      const stack =
+        typeof err === "object" && err !== null && "stack" in err
+          ? (err as { stack: string }).stack
+          : undefined;
+      const message = err instanceof Error ? err.message : String(err);
+      new EmulatorLog("FATAL", "runtime-error", stack ? stack : String(err)).log();
+      res.status(500).send(message);
     }
   });
   app.listen(process.env.PORT, () => {