Skip to content

Migrate linter from TSLint to ESLint with TypeScript support#322

Open
inlined wants to merge 3 commits into
masterfrom
eslint-upgrade
Open

Migrate linter from TSLint to ESLint with TypeScript support#322
inlined wants to merge 3 commits into
masterfrom
eslint-upgrade

Conversation

@inlined

@inlined inlined commented Jun 23, 2026

Copy link
Copy Markdown
Member

Security Audit & Remediation: firebase-functions-test (ESLint Upgrade)

A. Previous CVEs

B. Changes Made

  • Removed unmaintained and deprecated tslint package and its vulnerable transitive dependency tree (minimatch, js-yaml).
  • Installed modern eslint@^8.57.0, @typescript-eslint/eslint-plugin@^7.18.0, @typescript-eslint/parser@^7.18.0, and typescript@^5.4.5.
  • Created .eslintrc.json configured with TypeScript support and equivalent linting rules parity.
  • Updated package.json lint script to eslint 'src/**/*.ts' 'spec/**/*.ts'.

C. Remaining CVEs

  • Transitive CVEs in firebase-tools, firebase-admin, and mocha (addressed in companion security audit PRs).

D. Introduced CVEs

  • None

E. Testing Strategy

  • Executed updated linter (npm run lint) -> 0 errors.
  • Executed unit test suite (npm test) -> 118 passing tests (100% pass rate).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's linting configuration from TSLint to ESLint by removing tslint.json, adding .eslintrc.json, updating package.json dependencies, and revising the lint script. The review feedback identifies two critical issues in package.json: the specified TypeScript version (^5.9.3) is invalid and incompatible with the ESLint plugin, and the lint script uses single quotes which will fail on Windows environments. It is recommended to use a valid TypeScript version like ^5.5.4 and escape double quotes in the npm script for cross-platform compatibility.

Comment thread package.json Outdated
Comment thread package.json Outdated
@inlined inlined requested a review from Berlioz June 23, 2026 19:35

@Berlioz Berlioz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants