Migrate linter from TSLint to ESLint with TypeScript support#322
Open
inlined wants to merge 3 commits into
Open
Migrate linter from TSLint to ESLint with TypeScript support#322inlined wants to merge 3 commits into
inlined wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project's linting configuration from TSLint to ESLint by removing tslint.json, adding .eslintrc.json, updating package.json dependencies, and revising the lint script. The review feedback identifies two critical issues in package.json: the specified TypeScript version (^5.9.3) is invalid and incompatible with the ESLint plugin, and the lint script uses single quotes which will fail on Windows environments. It is recommended to use a valid TypeScript version like ^5.5.4 and escape double quotes in the npm script for cross-platform compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: firebase-functions-test (ESLint Upgrade)
A. Previous CVEs
minimatchviatslint(Severity: High)minimatchviatslint(Severity: High)minimatchviatslint(Severity: High)minimatchviatslint(Severity: High)js-yamlviatslint(Severity: Moderate)js-yamlviatslint(Severity: Moderate)B. Changes Made
tslintpackage and its vulnerable transitive dependency tree (minimatch,js-yaml).eslint@^8.57.0,@typescript-eslint/eslint-plugin@^7.18.0,@typescript-eslint/parser@^7.18.0, andtypescript@^5.4.5..eslintrc.jsonconfigured with TypeScript support and equivalent linting rules parity.package.jsonlint script toeslint 'src/**/*.ts' 'spec/**/*.ts'.C. Remaining CVEs
firebase-tools,firebase-admin, andmocha(addressed in companion security audit PRs).D. Introduced CVEs
E. Testing Strategy
npm run lint) -> 0 errors.npm test) -> 118 passing tests (100% pass rate).