Skip to content

dataconnect(chore): address zizmor warnings in dataconnect*.yml - #8517

Merged
dconeybe merged 8 commits into
mainfrom
dconeybe/dataconnect/zizmor
Aug 8, 2026
Merged

dataconnect(chore): address zizmor warnings in dataconnect*.yml#8517
dconeybe merged 8 commits into
mainfrom
dconeybe/dataconnect/zizmor

Conversation

@dconeybe

@dconeybe dconeybe commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The first zizmor failiure was this:

 INFO zizmor: 🌈 zizmor v1.29.0
 WARN collect_inputs: zizmor::registry::input: failed to validate file://.github/workflows/dataconnect_demo_app.yml as workflow: input does not match expected validation schema
 WARN collect_inputs: zizmor::registry::input: failed to validate file://.github/workflows/dataconnect.yml as workflow: input does not match expected validation schema
fatal: no audit was performed
error: no inputs collected
  |
  = help: collection yielded no auditable inputs
  = help: at least one valid, auditable input must be given

Caused by:
    no inputs collected

This was fixed in commit f12f31e by adding type: string to each workflow_dispatch input.

The remaining warnings were ref-version-mismatch, excessive-permissions, artipacked, and template-injection.

I ran zizmor locally with this command:

podman run --rm -v "$(pwd):/workspace" -w /workspace ghcr.io/zizmorcore/zizmor:1.29.0 .github/workflows/dataconnect*.yml --gh-token $(gh auth token) --min-severity=medium

which produced the following output after this PR:

No findings to report. Good job! (2 ignored, 13 suppressed)

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe
dconeybe marked this pull request as ready for review August 7, 2026 14:56
@dconeybe

dconeybe commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Note that the failing github actions cannot possibly be related to the changes in this PR as this PR's changes only affect the two dataconnect yaml workflow files, all of whose jobs passed.

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe
dconeybe merged commit 8959611 into main Aug 8, 2026
318 of 337 checks passed
@dconeybe
dconeybe deleted the dconeybe/dataconnect/zizmor branch August 8, 2026 01:55
@github-actions github-actions Bot mentioned this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants