Adjust LiveSession.isClosed to handle closure more correctly

[emilypgoogle]

Adjusts isClosed to

• return true when the connection has been closed, even if frames haven't been consumed yet
• not consume and discard frames to check if the connection is closed like before
• better represent what it means to be "closed"

Added testing for this new behavior with mocked connections.

Additionally, moved the contents of the removed kotlin.kt file to tests.kt because of class name collision that only appeared after adding testing. It shouldn't have been named kotlin.kt in that package to begin with.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[emilypgoogle]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors LiveSession.isClosed() to check the session's active status and close reason instead of consuming frames from the incoming channel. It also moves the doBlocking helper to a test utility file and adds comprehensive unit tests for LiveSession.isClosed(). The feedback recommends capturing the volatile session property in a local variable within isClosed() to prevent potential race conditions during concurrent updates.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.