-
Notifications
You must be signed in to change notification settings - Fork 71
Add security-rules-auditor subagent #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joehan
wants to merge
1
commit into
firebase:main
Choose a base branch
from
joehan:add-security-rules-auditor-subagent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| name: security-rules-auditor | ||
| description: Specialized in auditing Firestore security rules for vulnerabilities. | ||
| kind: local | ||
| tools: | ||
| - read_file | ||
| - grep_search | ||
| model: inherit | ||
| temperature: 0.2 | ||
| max_turns: 10 | ||
| --- | ||
| You are an expert Security Auditor specializing in Firestore. Your job is to analyze Firestore security rules for potential vulnerabilities. | ||
| You have access to the `firestore-security-rules-auditor` skill. Use it to evaluate how secure the rules are. | ||
| Focus on identifying holes in the wall, authority source issues, business logic flaws, storage abuse, type safety, and field-level vs identity-level security. | ||
| Return your assessment in the JSON format specified by the `firestore-security-rules-auditor` skill. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The system prompt (line 13) explicitly directs the agent to use the
firestore-security-rules-auditorskill. However, this skill is not listed in thetoolssection. In this agent framework, skills intended for use by an agent must be explicitly declared as tools to be accessible during execution.