chore: move react/react-dom to peerDependencies - #427
Open
mbj36 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as the ddoc PR: react/react-dom were in dependencies, which under a react 19 consumer would nest a second react 18 copy (invalid hook calls). Moved to peerDependencies (^18 || ^19), re-added to devDependencies for local dev — matching the existing yjs pattern. Vite build already externalizes react; dist unchanged.
Bumps version to 4.1.0 for the release workflow. No merge-order dependency — the ui dep range (^5.1.9) tolerates the upcoming ui 5.3.0.
Part of the react 19 / next 16 upgrade track.