chore: move react/react-dom to peerDependencies - #556
Open
mbj36 wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react/react-dom were in dependencies. Today npm dedupes them against the app's react 18, but the moment a consumer moves to react 19, ^18.2.0 can't resolve to the root copy and npm installs a second nested react 18 under this package — two react instances, invalid-hook-call crashes at runtime.
Moved to peerDependencies (^18 || ^19), re-added to devDependencies for local dev/build — same pattern we already use for yjs. Vite config already externalizes react so the dist bundle is unchanged. Also bumps usehooks-ts floor to ^3.1.1 (react 19 peer), version to 4.4.0 for the release workflow, and the @fileverse/ui peer pin to 5.3.0 (published today with react 19 peer support — fileverse-ui#92).
Ready to merge — no remaining order constraints.
Known follow-up (not in this PR): vaul ^0.9.1 peer caps at react 18 — needs the 1.x bump (drawer visual QA) or an app-side override before consumers run react 19.
Part of the react 19 / next 16 upgrade track.