fix: re-check embed allowlist on iframe render - #543
Open
resistanceisliberty wants to merge 2 commits into
Open
Conversation
Collab and non-UI write paths can introduce iframe nodes that skip setIframe/parseHTML allowlisting. Validate src before mounting or exporting embeds, require HTTPS, and export a CSP frame-src helper for host apps (demo sets the same header).
|
Someone is attempting to deploy a commit to the fileverse Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed the embed allowlist only runs on the insert/paste path, not when an iframe is actually rendered. With collab, a node can show up in the document without going through that UI check, so a hostile
srccould load for anyone who opens the doc; including view-only.This PR re-checks the existing allowlist before mounting iframes (and on a couple of related write/export paths), restricts embeds to HTTPS, and exports a matching host CSP
frame-srchelper (demo Vite headers set the same policy).Test plan
npx vitest run package/utils/is-allowed-embed-src.test.tssrcshows blocked UI and doesn't load in the network panelhttp://embeds are rejected