-
Notifications
You must be signed in to change notification settings - Fork 24
fix(py,ts): support OME-Zarr RFC-3 (arbitrary axis dimensions, names, types, ordering) #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vboussot
wants to merge
21
commits into
fideus-labs:main
Choose a base branch
from
vboussot:fix/rfc3-axes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
cda11dc
fix(py,ts): correct the v0.4 axis model — optional `type`, unique names
vboussot 3287a21
feat(py): add the OME-Zarr 1.0-DEV version and its metadata model
vboussot 900bfb0
feat(py): gate the RFC-3 axis model on OME-Zarr 1.0-DEV
vboussot 4476752
feat(ts): mirror the 1.0-DEV version gate in the TypeScript port
vboussot b9c9d13
fix(py,ts): address 1.0-DEV review feedback on the axis model
vboussot 874c0c3
fix(py): require 2 or 3 'space' axes below 1.0-DEV, matching the TS rule
vboussot 6c9a7d3
refactor(py,ts): rename the OME-Zarr 1.0-DEV model to 0.9.dev1
vboussot fc34da0
fix(py,ts): let a v0.6 array coordinate system satisfy the spatial-ax…
vboussot ed15671
fix(py,ts): describe the write gate accurately and lock the RFC-3 ver…
vboussot f473718
feat(py): offer 0.9.dev1 as an `ngff-zarr upgrade` target
vboussot deb9068
docs: describe the opt-in 0.9.dev1 version
vboussot d993b9f
chore(py,ts): complete the 0.9.dev1 type hints and drop a duplicated …
vboussot 7db1eb5
fix(ts): report the read version and gate the axes the writer serializes
vboussot 9510791
fix(py,ts): raise on a non-canonical axis class order like every othe…
vboussot b61273c
test(py,ts): lock the refusal of a non-canonical axis class order
vboussot 650d797
fix(py): restore axis-names-unique in the rule table and pin both tables
vboussot 8cc1a64
fix(py): keep the axis type vocabulary in the 0.9.dev1 model
vboussot a3e8190
fix(ts): validate a store against the version it declares
vboussot 267fc96
fix(py,ts): gate the axes each target version writes, with one message
vboussot 0f08d17
test(py,ts): lock axis-names-unique's position in the evaluation order
vboussot 7652f15
fix(py,ts): type the axis unit as the vocabulary or any string
vboussot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.