Skip to content

fix(cli): invalidate cached docs bundle when CLI version changes #15527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesandlord wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(cli): invalidate cached docs bundle when CLI version changes #15527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc727b
fix(cli): invalidate cached docs bundle when CLI version changes
devin-ai-integration[bot] Apr 28, 2026
a851abb
fix(cli): fully remove old bundle before extraction, defer ETag write
devin-ai-integration[bot] Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli/cli/changes/unreleased/fix-stale-docs-bundle-cache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- summary: |
Fix stale docs preview bundle on Windows by fully removing old bundle before
extracting and deferring ETag write until all post-processing succeeds.
type: fix
18 changes: 7 additions & 11 deletions packages/cli/docs-preview/src/downloadLocalDocsBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { execSync } from "child_process";
import cliProgress from "cli-progress";
import decompress from "decompress";
import { cpSync, existsSync, lstatSync, mkdirSync, symlinkSync } from "fs";
import { mkdir, readFile, rename, rm, writeFile } from "fs/promises";
import { mkdir, readFile, rm, writeFile } from "fs/promises";
import { homedir } from "os";
import path from "path";
import tmp from "tmp-promise";
Expand Down Expand Up @@ -354,14 +354,8 @@ export async function downloadBundle({

const absolutePathToPreviewFolder = getPathToPreviewFolder({ app });
if (await doesPathExist(absolutePathToPreviewFolder)) {
const oldBundlePath = AbsoluteFilePath.of(`${absolutePathToPreviewFolder}-old-${Date.now()}`);
logger.debug(`Moving previously cached bundle to: ${oldBundlePath}`);
await rename(absolutePathToPreviewFolder, oldBundlePath);

// Delete the old bundle asynchronously so it doesn't block the rest of the setup
rm(oldBundlePath, { recursive: true }).catch((error) => {
logger.debug(`Failed to remove old bundle at ${oldBundlePath}: ${error}`);
});
logger.debug(`Removing previously cached bundle at: ${absolutePathToPreviewFolder}`);
await rm(absolutePathToPreviewFolder, { recursive: true, force: true });
}
await mkdir(absolutePathToPreviewFolder, { recursive: true });

Expand Down Expand Up @@ -447,8 +441,6 @@ export async function downloadBundle({
}
}

// write etag
await writeFile(eTagFilepath, eTag);
logger.debug(`Downloaded bundle to ${absolutePathToBundleFolder}`);

if (app) {
Expand Down Expand Up @@ -542,6 +534,10 @@ export async function downloadBundle({
}
}

// Write etag only after all post-processing succeeds, so a failed
// extraction won't be treated as cached on the next run.
await writeFile(eTagFilepath, eTag);

return {
type: "success"
};
Expand Down
Loading