fix(mocktail): name the verified mock on call-count mismatch - #275
Open
AzazelSensei wants to merge 1 commit into
Open
fix(mocktail): name the verified mock on call-count mismatch#275AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
verify(() => a.foo(b.bar())) records b.bar when bar() has a non-nullable return (TypeError aborts the closure). The count error then looks like a.foo was called N times. Include the mock type and member in the called() reason so the failure names the invocation that was actually checked. Fixes felangel#179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Fixes #179.
verify(() => mockA.doIt(mockB.getValue()))does not checkdoIt.getValue()has a non-nullable return, so the dummynullfrom verify throws a TypeError and the rest of the closure never runs..called(1)then fails with Expected 1 / Actual 6 and never says which mock was counted.I put the mock type and member on that error so it reads
Unexpected number of calls of MockDataProvider.getValue.The call you want is still
verify(() => mockA.doIt('mock value')).Type of Change
Testing
verifyverifies against wrong class when a second mock is called within the sameverifycall #179 snippetdart test— 221 passingdart analyze --fatal-infos— clean