docs: clarify async exception verification - #272
Open
a1573595 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Addresses #247.
This documents the async timing behavior when
throwsAis used with aFutureor a closure returning aFuture, and adds regression coverage for verifying mock interactions after the async exception expectation has been awaited.expect(..., throwsA(...))registers the async matcher but does not wait before the next statement runs. In the issue reproduction, the code under test yields after the firstawait, so immediateverifycalls can run before later mocked calls have happened.The documented pattern is to use
await expectLater(...)before verifying interactions.Added regression coverage showing that after
await expectLater(...), all calls made before the thrown async exception remain verifiable.Verification:
git diff --checkfvm dart analyzefvm dart testfvm dart test --coverage=coveragefvm dart run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib430/430 = 100.00%Type of Change