fix: compare records with == in objectsEquals - #216
Open
AzazelSensei wants to merge 1 commit into
Open
Conversation
Dart record equality already treats 1 and 1.0 as equal. The runtimeType check after that made NumInRecord((value: 1)) != NumInRecord((value: 1.0)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
objectsEqualscomparedruntimeTypebefore==for records.(value: 1) == (value: 1.0)is true in Dart, butNumInRecord((value: 1)) == NumInRecord((value: 1.0))was false.Use
==for records, same as the snippet on #211.Related PRs
Todos
Steps to Test or Reproduce
Impact to Remaining Code Base
This PR will affect: