Repository navigation
Fix unintended prefix matches in archive member selection - #557
Open
mikegit123git wants to merge 2 commits into
Open
mikegit123git wants to merge 2 commits into
mikegit123git wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unintended prefix matches when extracting selected archive members using
UnzipandUntar.Previously, selecting a directory such as
selectedcould also extract unrelated entries likeselected-extra/file.txtorselectedfile.txt.Similarly, selecting an exact file such as
selected/ok.txtcould unintentionally includeselected/ok.txt.bak.This happens because the current implementation uses
startswith()without checking path-component boundaries.Changes
_is_selected_member()helper to match exact archive members or descendants of selected directories.ExtractorProcessorto filter returned file paths using the same matching logic.The fix is focused on archive member matching and does not modify the underlying extraction or cache management routines.
Verification
The same 20 regression tests were executed against both the original and patched source.
All 12 previously failing tests pass after applying the fix.
Additional local verification
FLY002warnings excluded.These checks confirm that the patch prevents unintended prefix matches while preserving the extraction and caching behaviors covered by the tests.
Cross-platform CI verification is still pending.
Related issue
Closes #556