Skip to content

ci: always gather logs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjbs wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −10
Open

ci: always gather logs #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Dobby/Boxmate/App/Command/ciplan.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ sub _template_program {
[ newt_full => () ],
# [ cassandane => () ],
[ stop_services => () ],
[ log_gather => () ],
];
}

Expand Down
28 changes: 19 additions & 9 deletions misc/test-runner-on-vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ sub STEP_cassandane ($self, @args) {
return;
}

sub STEP_log_gather ($self) {
sub gather_logs ($self) {
START("gathering logs");

my $root = $self->root;
Expand Down Expand Up @@ -487,21 +487,31 @@ my $testproc = TestProcess->new({

my @instructions = $plan->{program}->@*;

for my $instruction (@instructions) {
my ($name, @args) = @$instruction;
eval {
for my $instruction (@instructions) {
my ($name, @args) = @$instruction;

my $method = "STEP_$name";
my $method = "STEP_$name";

unless ($testproc->can($method)) {
# XXX: validate all this before starting any work!
die "Test runner has no implementation for $name step\n";
unless ($testproc->can($method)) {
# XXX: validate all this before starting any work!
die "Test runner has no implementation for $name step\n";
}

$testproc->$method(@args);
}
};

$testproc->$method(@args);
}
my $error = $@;

FINISH_CURR();

$self->gather_logs;

if ($error) {
die $error;
}

if ($testproc->is_passing) {
say "All tests successful!";
exit 0;
Expand Down
Loading