feat(CommunityPost): show the body whole where the post is the destination - #5263
feat(CommunityPost): show the body whole where the post is the destination#5263sauldom102 wants to merge 1 commit into
Conversation
…ation A post opened in a dialog was still clamped at five lines, with nothing behind the clamp: `descriptionExpandable` is what puts a "See more" under it, and without that the reader simply never reaches the end of what they opened. `noDescriptionClamp` is for the containers that ARE the post — a dialog, a page — where the body is what the reader came for. A feed leaves it off: posts a page long each are what makes a feed unskimmable, which is what the clamp is for. It also suppresses "See more" outright, so a body already shown whole can't offer to expand into itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🔍 Review policy: SDS modulesEvery changed file belongs to a module with a dedicated owner. Module owners are the only required reviewers (rule 1) — their approval is enforced natively by GitHub through CODEOWNERS. Module ownership (via CODEOWNERS)
Declared in each module's No approvals required beyond the module code owners. How this was decided
Policy source: |
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
✅ Storybook docs — no pages lostEvery page reachable on ✏️ 6 updated ✏️ Updated — 6 page(s)/story/stories across 1 file(s)The source file behind each of these changed. Detection is per file, so editing one story flags its siblings too.
Links point at this PR's Storybook build — browse the full Storybook. Snapshot of the Storybook index (docs pages + stories) compared against |
📦 Alpha Package Version PublishedUse Use |
🔍 Visual review for your branch is published 🔍Here are the links to: |
✅ No breaking public API changesNo public exports were removed, renamed, or had existing props/types changed in a breaking way compared to Comparing
|
♿ Accessibility (axe) — components changed in this PR2 issues across 2 stories — all non-blocking (
Scope: only stories in the files/component folders this PR changed. It can't yet flag downstream ripple from shared-code/token changes, or diff against |
Coverage Report for packages/react
File Coverage
|
||||||||||||||||||||||||||||||||||||||
What
Adds
noDescriptionClamptoCommunityPost: the description renders unclamped, and "See more" is suppressed.Why
A post opened in
F0CarouselDialogis still clamped at five lines with nothing behind the clamp —descriptionExpandableis what puts a "See more" under it, and without that the reader never reaches the end of the post they just opened. The Home's Community posts widget in the monorepo hit exactly this: the dialog shows the post, the post shows an ellipsis.The prop is for the containers that ARE the post (a dialog, a page). A feed leaves it off — posts a page long each are what makes a feed unskimmable, which is what the clamp is for.
Notes
NewHomeLayout's story now passes it in the dialog'sCommunityPostDetail, which is where this shows up.descriptionExpandableon, and the clamp coming back when the prop goes away.🤖 Generated with Claude Code