Skip to content

feat(CommunityPost): show the body whole where the post is the destination - #5263

Draft
sauldom102 wants to merge 1 commit into
mainfrom
feat/community-post-full-description
Draft

feat(CommunityPost): show the body whole where the post is the destination#5263
sauldom102 wants to merge 1 commit into
mainfrom
feat/community-post-full-description

Conversation

@sauldom102

Copy link
Copy Markdown
Collaborator

What

Adds noDescriptionClamp to CommunityPost: the description renders unclamped, and "See more" is suppressed.

Why

A post opened in F0CarouselDialog is still clamped at five lines with nothing behind the clampdescriptionExpandable is what puts a "See more" under it, and without that the reader never reaches the end of the post they just opened. The Home's Community posts widget in the monorepo hit exactly this: the dialog shows the post, the post shows an ellipsis.

The prop is for the containers that ARE the post (a dialog, a page). A feed leaves it off — posts a page long each are what makes a feed unskimmable, which is what the clamp is for.

Notes

  • NewHomeLayout's story now passes it in the dialog's CommunityPostDetail, which is where this shows up.
  • Two tests: whole body + no "See more" even with descriptionExpandable on, and the clamp coming back when the prop goes away.

🤖 Generated with Claude Code

…ation

A post opened in a dialog was still clamped at five lines, with nothing behind
the clamp: `descriptionExpandable` is what puts a "See more" under it, and
without that the reader simply never reaches the end of what they opened.

`noDescriptionClamp` is for the containers that ARE the post — a dialog, a page
— where the body is what the reader came for. A feed leaves it off: posts a page
long each are what makes a feed unskimmable, which is what the clamp is for.

It also suppresses "See more" outright, so a body already shown whole can't
offer to expand into itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions github-actions Bot added feat react Changes affect packages/react labels Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Review policy: SDS modules

Every changed file belongs to a module with a dedicated owner. Module owners are the only required reviewers (rule 1) — their approval is enforced natively by GitHub through CODEOWNERS.

Module ownership (via CODEOWNERS)

Module Code owner Files touched
sds/Home @factorialco/foundations 3

Declared in each module's package.yml. Wrong owner? Edit the manifest and run pnpm ownership.

No approvals required beyond the module code owners.

How this was decided
  • PRs touching only sds/ modules require their owners and nothing else.
  • Otherwise, docs-only changes (*.md, *.mdx, *.stories.tsx, anything in __stories__/) → one f0-general approval.
  • Otherwise, feat: titles → one f0-devs and one f0-designers approval. Not a feature? Fix the title prefix.
  • Anything else → one f0-devs approval.
  • Add the needs-design-review label to also request a design approval on any PR.
  • Creating a new sds/ module (new package.yml) additionally requires an f0-general approval.

Policy source: ownership/review-policy.ts · Team members: ownership/teams.yml

@github-actions

Copy link
Copy Markdown
Contributor

✅ No New Circular Dependencies

No new circular dependencies detected. Current count: 0

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

✅ Storybook docs — no pages lost

Every page reachable on main is still reachable here.

✏️ 6 updated

✏️ Updated — 6 page(s)/story/stories across 1 file(s)

The source file behind each of these changed. Detection is per file, so editing one story flags its siblings too.

Links point at this PR's Storybook build — browse the full Storybook.

Snapshot of the Storybook index (docs pages + stories) compared against main. Non-blocking.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Alpha Package Version Published

Use pnpm i github:factorialco/f0#npm/alpha-pr-5263 to install the package

Use pnpm i github:factorialco/f0#cf3d256df072b644d860f08cbc90b22ecc7ca297 to install this specific commit

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Visual review for your branch is published 🔍

Here are the links to:

@github-actions

Copy link
Copy Markdown
Contributor

✅ No breaking public API changes

No public exports were removed, renamed, or had existing props/types changed in a breaking way compared to main.

Comparing f0, experimental and ai against main. Adding components, types, or optional props is safe. This check is non-blocking.

⚠️ Could not analyze component-status (no-base) — a build may have failed; results may be incomplete.

@github-actions

Copy link
Copy Markdown
Contributor

♿ Accessibility (axe) — components changed in this PR

2 issues across 2 stories — all non-blocking (todo).

Story Rule WCAG Impact Nodes Mode
Domain specific/Home/Communities/Post/CommunityPost / With Custom Button Without Label button-name WCAG 4.1.2 A (2.0) critical 1 🟡 todo
Domain specific/Home/NewHomeLayout / Glyph Action color-contrast WCAG 1.4.3 AA (2.0) serious 1 🟡 todo

Scope: only stories in the files/component folders this PR changed. It can't yet flag downstream ripple from shared-code/token changes, or diff against main (planned: base-vs-head delta).

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 69% 29118 / 42198
🔵 Statements 67.95% 30802 / 45325
🔵 Functions 61.84% 6950 / 11238
🔵 Branches 61.64% 21808 / 35374
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/sds/Home/Communities/Post/CommunityPost/index.tsx 90.19% 69.33% 75% 93.47% 187, 198, 229, 329-338, 470-501
Generated in workflow #17523 for commit ac5865d by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat react Changes affect packages/react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant