Skip to content

ci(npm-publish): group event guards so manual publish is not skipped #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eliseo-juan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci(npm-publish): group event guards so manual publish is not skipped #5226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions .github/workflows/npm-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,17 @@ on:
jobs:
publish-react:
name: "[⚛️ REACT] Publish to npm"
# Prevents running on the release-please branch
# For workflow_run trigger we need to check if the workflow_run was successful and if the new_version output was set to not run on it if no new version was released
# The per-event guards must stay parenthesised as one group: `&&` binds
# tighter than `||`, so flattening the chain applies the tag filter to the
# first branch only and silently skips every manual dispatch.
if: |
contains(github.event.release.tag_name, 'react-v') &&
github.head_ref != 'release-please--branches--master' && !contains(github.event.pull_request.labels.*.name, 'autorelease') &&
github.event_name == 'workflow_dispatch' || github.event_name == 'release' ||
(github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
github.head_ref != 'release-please--branches--master' &&
!contains(github.event.pull_request.labels.*.name, 'autorelease') &&
(
(github.event_name == 'release' && contains(github.event.release.tag_name, 'react-v')) ||
(github.event_name == 'workflow_dispatch' && contains(github.event.inputs.release_tag, 'react-v')) ||
(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
)
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -86,13 +90,14 @@ jobs:

publish-react-native:
name: "[📱 REACT NATIVE] Publish to npm"
# Prevents running on the release-please branch
# For workflow_run trigger we need to check if the workflow_run was successful and if the new_version output was set to not run on it if no new version was released
if: |
contains(github.event.release.tag_name, 'react-native-v') &&
github.head_ref != 'release-please--branches--master' && !contains(github.event.pull_request.labels.*.name, 'autorelease') &&
github.event_name == 'workflow_dispatch' || github.event_name == 'release' ||
(github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
github.head_ref != 'release-please--branches--master' &&
!contains(github.event.pull_request.labels.*.name, 'autorelease') &&
(
(github.event_name == 'release' && contains(github.event.release.tag_name, 'react-native-v')) ||
(github.event_name == 'workflow_dispatch' && contains(github.event.inputs.release_tag, 'react-native-v')) ||
(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
)
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -113,13 +118,14 @@ jobs:

publish-core:
name: "[🎯 CORE] Publish to npm"
# Prevents running on the release-please branch
# For workflow_run trigger we need to check if the workflow_run was successful and if the new_version output was set to not run on it if no new version was released
if: |
contains(github.event.release.tag_name, 'core-v') &&
github.head_ref != 'release-please--branches--master' && !contains(github.event.pull_request.labels.*.name, 'autorelease') &&
github.event_name == 'workflow_dispatch' || github.event_name == 'release' ||
(github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
github.head_ref != 'release-please--branches--master' &&
!contains(github.event.pull_request.labels.*.name, 'autorelease') &&
(
(github.event_name == 'release' && contains(github.event.release.tag_name, 'core-v')) ||
(github.event_name == 'workflow_dispatch' && contains(github.event.inputs.release_tag, 'core-v')) ||
(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.outputs.new_version)
)
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down
Loading