Skip to content

feat(F0Button): show a counter on buttons, styled right #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngelMsaa merged 11 commits into from
Aug 28, 2026
Merged

feat(F0Button): show a counter on buttons, styled right #5225

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
65ef0d2
feat(F0Button): render the counter in the neutral default type
AngelMsaa Aug 25, 2026
0133694
feat(F0Button): add 2px of breathing room before the counter
AngelMsaa Aug 25, 2026
e08eaad
fix(F0Button): center the counter pill in the button height
AngelMsaa Aug 25, 2026
44802da
fix(F0Button): widen the gap before the counter to 4px
AngelMsaa Aug 25, 2026
ff1f2fd
feat(F0Button): give the counter a dark pill on the primary variant
AngelMsaa Aug 25, 2026
775b04f
feat(F0Button): tighten the right padding when a counter is present
AngelMsaa Aug 27, 2026
2cb7619
test(F0Button): cover the counter render and counter-aware right padding
AngelMsaa Aug 27, 2026
29650ac
Merge branch 'main' into feat/collection-secondary-action-counter
AngelMsaa Aug 27, 2026
0cb2384
Merge branch 'main' into feat/collection-secondary-action-counter
AngelMsaa Aug 28, 2026
5f564f2
feat(F0Button): scale the counter, hide it at 0, dark on all solid va…
AngelMsaa Aug 28, 2026
6e891e4
feat(F0Button): refine the counter and document it
AngelMsaa Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/F0Button/internal-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export type ButtonInternalProps = Pick<
*/
variant?: ActionButtonVariant
/**
* The filters'counter value to display.
* A count shown in a neutral counter to the right of the label.
*/
counterValue?: number
/**
Expand Down
12 changes: 11 additions & 1 deletion packages/react/src/components/F0Button/internal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,17 @@ const ButtonInternal = forwardRef<
{iconPosition === "right" && iconNode}
{append}{" "}
{counterValue && (
<Counter value={counterValue} size="sm" type="selected" />
<span
className={cn(
"ml-1 inline-flex items-center",
// The default (primary) button is a solid dark-red field, so the
// light counter would wash out. Forcing the dark theme onto just
// the counter gives it a dark pill regardless of the app theme.
variant === "default" && "dark"
)}
>
<Counter value={counterValue} size="sm" type="default" />
</span>
)}
</div>
</Action>
Expand Down
Loading