chore(deps): update rust crate rmcp to v1.6.0#41
Conversation
ReviewCI: Clippy check is failing. The CI shows the Clippy job failed after upgrading rmcp to 1.3.0. This must be resolved before merging. Root cause to investigate: rmcp 1.3.0 includes a fix titled 'remove default type param from StreamableHttpService'. The project uses StreamableHttpService::new(...) in src/lib.rs:143 without an explicit type annotation, relying on type inference. Removing a default type parameter can break inference at call sites and may require an explicit type annotation. Cargo.toml/Cargo.lock mismatch: Cargo.toml still declares rmcp version 1.2.0 while Cargo.lock now resolves to 1.3.0. Technically valid (Cargo treats 1.2.0 as >=1.2.0, <2.0.0), but the minimum version specifier should be updated to 1.3.0 to match the resolved version and prevent unexpected downgrades. Action required: Fix the Clippy failure (likely by adding an explicit type parameter to the StreamableHttpService::new call in src/lib.rs) and update Cargo.toml to version = "1.3.0". |
| [[package]] | ||
| name = "rmcp" | ||
| version = "1.2.0" | ||
| version = "1.3.0" |
There was a problem hiding this comment.
rmcp 1.3.0 includes "remove default type param from StreamableHttpService" which can break type inference at call sites using StreamableHttpService::new(...) without an explicit type parameter. The Clippy CI job is failing — check if src/lib.rs:143 needs an explicit type annotation after this upgrade.
f8ccaa0 to
6a15b27
Compare
Review (rmcp 1.2.0 → 1.4.0)CI is still failing: Clippy and Tests both fail. The issues identified in the previous review remain unresolved. Blocking issuesClippy/compile failure — rmcp 1.3.0 removed the default type parameter from Cargo.toml version specifier not updated — NotesThe 1.3.0 and 1.4.0 releases include two positive security fixes:
Once the Clippy/build failure is fixed and Cargo.toml is updated to |
6a15b27 to
30c3a86
Compare
Review: rmcp 1.2.0 → 1.5.0Lock-file-only bump — no source changes. Code inspection against the release notes across all three skipped minor versions: v1.3.0 — v1.4.0 — All other changes (transport constructors, session keep-alive, protocol version 2025-11-25 support, error body surfacing on 4xx) are additive and don't touch code paths used here. No compile failures or logic errors were identified by static analysis. Recommend confirming CI passes before merge. |
30c3a86 to
53ade11
Compare
Code ReviewThis Renovate-generated PR updates SummaryThe diff is exclusively One behavioral change worth verifyingOrigin header validation added in v1.6.0 (#823, #826): If the MCP server receives requests from clients whose No issues found with
|
- Use StreamableHttpServerConfig builder methods (struct is now #[non_exhaustive]) - Remove unused tool_router field; #[tool_handler] now calls Self::tool_router() directly - Collapse nested if into match guard for clippy::collapsible_match
Review: rmcp 1.2.0 → 1.6.0Clean dependency upgrade. All API-breaking changes from the four minor versions are correctly adapted.
Security improvement (positive): v1.4.0 and v1.6.0 add Host and Origin header validation for the streamable-HTTP transport — a meaningful CSRF/confused-deputy mitigation this server gains for free. Transitive No CLAUDE.md violations, no suppressed errors introduced, no high-signal issues. LGTM. |
This PR contains the following updates:
1.2.0→1.6.0Release Notes
modelcontextprotocol/rust-sdk (rmcp)
v1.6.0Compare Source
Added
Fixed
Other
v1.5.0Compare Source
Added
Fixed
Other
v1.4.0Compare Source
Added
Fixed
Other
v1.3.0Compare Source
Added
Fixed
Other
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.