Skip to content

Fix params_with_grad in FSDP when the model has frozen parameters #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whbldhwj wants to merge 1 commit into
base: ngoyal_changes_for_pp_fp8_akadian
Choose a base branch
from
Open

Fix params_with_grad in FSDP when the model has frozen parameters #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fairscale/nn/data_parallel/fully_sharded_data_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ def _cast_buffers(
@property
def params_with_grad(self) -> List[Parameter]:
"""[p for p in self.parameters() if p.grad is not None]"""
return [p for p in self.parameters() if (p.grad is not None or p.main_grad is not None)]
return [p for p in self.parameters() if (p.requires_grad and (p.grad is not None or p.main_grad is not None))]

@torch.no_grad()
def clip_grad_norm_(
Expand Down