[Celestica] Leh800bcls: Fix CPU-originated packet targeting failure in QueuePerHost tests on multi-NPU platforms - #1500
Open
gang-tao wants to merge 1 commit into
Open
Conversation
…n QueuePerHost tests on multi-NPU platforms
Contributor
|
@jchallag has imported this pull request. If you are a Meta employee, you can view this in D115625598. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
In Multi-Switch (Split Agent) configurations, QueuePerHost hardware tests (specifically AgentQueuePerHostRouteTest) failed when run on secondary NPUs (such as NPU1). The test expects 2 packets to be queued on the target port's queue, but instead gets 0.
Root Cause
When injecting CPU-originated (switched) packets during the verification phase, QueuePerHostTestUtils invoked sendPacketSwitchedAsync(std::move(pkt)) without specifying a target SwitchID. In multi-NPU environments, this single-switch fallback routes all CPU-switched packets to Switch 0. Consequently, when the test runner ran on Switch 1, packets were routed to Switch 0 instead of Switch 1, leaving Switch 1's queues empty and causing the test to fail.
Solution
In QueuePerHostTestUtils.cpp, retrieve the correct SwitchID of the active port under test using the SwSwitch ScopeResolver. Explicitly pass this SwitchID to sendPacketSwitchedAsync(std::move(pkt), {switchId}), ensuring CPU-originated switched packets are targeted to the correct active hardware agent.
Test Plan
Tests running on NPU0 and NPU1 on the Leh800bcls platform both passed: