[Nexthop][fboss2-dev] Add delete interface description and mtu - #1495
Open
vybhav-nexthop wants to merge 1 commit into
Open
[Nexthop][fboss2-dev] Add delete interface description and mtu#1495vybhav-nexthop wants to merge 1 commit into
vybhav-nexthop wants to merge 1 commit into
Conversation
Fill in the `delete interface` gaps where `config interface` can set an
attribute but nothing could unset it.
delete interface <port-list> description
Valueless reset of the optional sw.ports[*].description.
delete interface <port-list> mtu
Valueless reset of the optional sw.interfaces[*].mtu. The agent falls
back to Interface::kDefaultMtu when unset, so this is an
interface-level reset rather than a port-level one.
Both save with ConfigActionLevel::HITLESS, matching the config-side
setters; SaiSwitch has no prohibited-change guard for these fields.
`queue-config` is deliberately not included here: `delete interface
<port-list> queue-config` already clears portQueueConfigName upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Adds the missing
delete interfacecounterparts for attributes thatconfig interfacecan already set:delete interface <port-list> description— clears optionalsw.ports[*].descriptiondelete interface <port-list> mtu— clears optionalsw.interfaces[*].mtu(agent falls back toInterface::kDefaultMtu)Both are valueless resets on the existing flat
delete interface <ports> <attr>…form, saved HITLESS to match the config-side setters.queue-configis intentionally not part of this PR:delete interface <port-list> queue-configalready clearsportQueueConfigNameupstream.Test plan
CmdDeleteInterfaceTest(description, mtu, combined, idempotent)DeleteInterfaceTest.DeleteDescriptionAndMtu(set both → delete both; TearDown restores prior description/mtu)