Skip to content

[Nexthop][fboss2-dev] fboss2 config/delete protocol bgp policy routing-policy commands #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hillol-nexthop wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Nexthop][fboss2-dev] fboss2 config/delete protocol bgp policy routing-policy commands #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f7d3c48
Unify agent/BGP config session + decouple ConfigSession header
hillol-nexthop Jul 24, 2026
8d74003
Remove comments regarding destructor in ConfigSession
hillol-nexthop Jul 31, 2026
34f671e
Fix rebase fallout: orphaned ConfigSession includes, stale findFirstE…
hillol-nexthop Jul 31, 2026
03823a2
fboss2 config session seeds BGP config from the daemon's config path
hillol-nexthop Aug 7, 2026
f6272b5
fboss2 `config protocol bgp global` command
hillol-nexthop Jun 29, 2026
078319c
bgp global command fixes
hillol-nexthop Jul 16, 2026
dd15933
Verify committed global config via bgpd getRunningConfig RPC
hillol-nexthop Jul 17, 2026
7a899f7
fboss2 BGP test base reads the daemon's config path
hillol-nexthop Aug 11, 2026
c40cd77
NOS-6585..NOS-6615: fboss2 config/delete protocol bgp neighbor commands
hillol-nexthop Aug 7, 2026
fb46784
NOS-6616..NOS-6642: fboss2 config/delete protocol bgp peer-group comm…
hillol-nexthop Aug 7, 2026
44721ea
NOS-6643..NOS-6648: fboss2 config/delete protocol bgp policy as-path-…
hillol-nexthop Aug 7, 2026
40276bd
NOS-6643..NOS-6648: fboss2 bgp policy as-path-list entry subcommand
hillol-nexthop Aug 7, 2026
7ac6d9e
NOS-6649..NOS-6656: fboss2 config/delete protocol bgp policy communit…
hillol-nexthop Jul 28, 2026
a6457d4
NOS-6649..NOS-6656: fboss2 bgp policy community-list community subcom…
hillol-nexthop Aug 7, 2026
8aaa373
NOS-6657..NOS-6670: fboss2 config/delete protocol bgp policy prefix-list
hillol-nexthop Aug 6, 2026
a035c07
NOS-6657..NOS-6670: fboss2 bgp policy prefix-list entry subcommand
hillol-nexthop Aug 7, 2026
dbcee87
NOS-6671, NOS-6689: fboss2 config/delete protocol bgp policy routing-…
hillol-nexthop Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 40 additions & 108 deletions cmake/CliFboss2.cmake
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions cmake/CliFboss2TestConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ add_executable(fboss2_cmd_config_test
fboss/cli/fboss2/test/config/CmdConfigAclRuleTest.cpp
fboss/cli/fboss2/test/config/CmdConfigArpTest.cpp
fboss/cli/fboss2/test/config/CmdConfigIcmpV4UnavailableSrcAddrTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpNeighborTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPolicyAsPathListTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPolicyCommunityListTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPolicyPrefixListTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPolicyRoutingPolicyTest.cpp
fboss/cli/fboss2/test/config/CmdConfigCoppTest.cpp
fboss/cli/fboss2/test/config/CmdConfigDhcpTest.cpp
fboss/cli/fboss2/test/config/CmdConfigHostnameTest.cpp
Expand Down Expand Up @@ -38,6 +44,12 @@ add_executable(fboss2_cmd_config_test
fboss/cli/fboss2/test/config/CmdConfigVlanStaticMacTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteAclRuleTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteArpTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpNeighborTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPolicyAsPathListTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPolicyCommunityListTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPolicyPrefixListTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPolicyRoutingPolicyTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteConfigInterfaceTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteDhcpTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteInterfaceIpv6NdpTest.cpp
Expand Down
7 changes: 7 additions & 0 deletions cmake/CliFboss2TestIntegrationTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ add_executable(fboss2_integration_test
fboss/cli/fboss2/test/integration_test/ConfigAdminDistanceTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigAclRuleTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigArpTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpGlobalTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpNeighborTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpPolicyCommunityListTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpPolicyPrefixListTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpPolicyRoutingPolicyTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpSessionTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigConcurrentSessionsTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigHostnameTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigIcmpV4UnavailableSrcAddrTest.cpp
Expand Down
131 changes: 40 additions & 91 deletions fboss/cli/fboss2/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,61 +1098,16 @@ cpp_library(
"commands/config/protocol/bgp/BgpConfigSession.cpp",
"commands/config/protocol/bgp/CmdConfigProtocolBgp.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobal.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalClusterId.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalConfedAsn.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalHoldTime.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalLocalAsn.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalNetwork6Add.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalRouterId.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitMaxGoldenVips.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitOverloadProtectionMode.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitPrefixLimit.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitTotalPathLimit.cpp",
"commands/config/protocol/bgp/neighbor/CmdConfigProtocolBgpNeighbor.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroup.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupConfedPeer.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDescription.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDisableIpv4Afi.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupEgressPolicy.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupIngressPolicy.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupMaxRoutes.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupNextHopSelf.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupPeerTag.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRemoteAsn.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRrClient.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimers.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersHoldTime.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersKeepalive.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersOutDelay.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersWithdrawUnprogDelay.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupV4OverV6Nh.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupWarningLimit.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupWarningOnly.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeer.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerAdvertiseLbw.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDescription.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDisableIpv4Afi.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerEgressPolicy.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerHoldTime.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerIngressPolicy.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLinkBandwidth.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLocalAddr.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerMaxRoutes.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop4.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop6.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHopSelf.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPassive.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerGroup.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerId.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRemoteAsn.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRrClient.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimers.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersKeepalive.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersOutDelay.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersWithdrawUnprogDelay.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerType.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerV4OverV6Nh.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerWarningLimit.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerWarningOnly.cpp",
"commands/config/protocol/bgp/policy/CmdConfigProtocolBgpPolicy.cpp",
"commands/config/protocol/bgp/policy/as-path-list/CmdConfigProtocolBgpPolicyAsPathList.cpp",
"commands/config/protocol/bgp/policy/as-path-list/entry/CmdConfigProtocolBgpPolicyAsPathListEntry.cpp",
"commands/config/protocol/bgp/policy/community-list/CmdConfigProtocolBgpPolicyCommunityList.cpp",
"commands/config/protocol/bgp/policy/community-list/community/CmdConfigProtocolBgpPolicyCommunityListCommunity.cpp",
"commands/config/protocol/bgp/policy/prefix-list/CmdConfigProtocolBgpPolicyPrefixList.cpp",
"commands/config/protocol/bgp/policy/prefix-list/entry/CmdConfigProtocolBgpPolicyPrefixListEntry.cpp",
"commands/config/protocol/bgp/policy/routing-policy/CmdConfigProtocolBgpPolicyRoutingPolicy.cpp",
"commands/config/protocol/static/CmdConfigProtocolStatic.cpp",
"commands/config/protocol/static/route/add/CmdConfigProtocolStaticRouteAdd.cpp",
"commands/config/ptp/CmdConfigPtp.cpp",
Expand Down Expand Up @@ -1199,6 +1154,14 @@ cpp_library(
"commands/delete/interface/ipv6/CmdDeleteInterfaceIpv6.cpp",
"commands/delete/interface/ipv6/ndp/CmdDeleteInterfaceIpv6Ndp.cpp",
"commands/delete/protocol/CmdDeleteProtocol.cpp",
"commands/delete/protocol/bgp/CmdDeleteProtocolBgp.cpp",
"commands/delete/protocol/bgp/neighbor/CmdDeleteProtocolBgpNeighbor.cpp",
"commands/delete/protocol/bgp/peer-group/CmdDeleteProtocolBgpPeerGroup.cpp",
"commands/delete/protocol/bgp/policy/CmdDeleteProtocolBgpPolicy.cpp",
"commands/delete/protocol/bgp/policy/as-path-list/CmdDeleteProtocolBgpPolicyAsPathList.cpp",
"commands/delete/protocol/bgp/policy/community-list/CmdDeleteProtocolBgpPolicyCommunityList.cpp",
"commands/delete/protocol/bgp/policy/prefix-list/CmdDeleteProtocolBgpPolicyPrefixList.cpp",
"commands/delete/protocol/bgp/policy/routing-policy/CmdDeleteProtocolBgpPolicyRoutingPolicy.cpp",
"commands/delete/protocol/static/CmdDeleteProtocolStatic.cpp",
"commands/delete/protocol/static/route/CmdDeleteProtocolStaticRoute.cpp",
"commands/delete/qos/CmdDeleteQos.cpp",
Expand Down Expand Up @@ -1249,47 +1212,25 @@ cpp_library(
"commands/config/mac/CmdConfigMac.h",
"commands/config/mac/aging_time/CmdConfigMacAgingTime.h",
"commands/config/protocol/CmdConfigProtocol.h",
"commands/config/protocol/bgp/BgpCliAttrHandlers.h",
"commands/config/protocol/bgp/BgpCliValueParsers.h",
"commands/config/protocol/bgp/BgpPeerAddr.h",
"commands/config/protocol/bgp/BgpConfigSession.h",
"commands/config/protocol/bgp/CmdConfigProtocolBgp.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobal.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalClusterId.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalConfedAsn.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalHoldTime.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalLocalAsn.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalRouterId.h",
"commands/config/protocol/bgp/neighbor/CmdConfigProtocolBgpNeighbor.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroup.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupConfedPeer.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDescription.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDisableIpv4Afi.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupEgressPolicy.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupIngressPolicy.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupMaxRoutes.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupNextHopSelf.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRemoteAsn.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRrClient.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimers.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersHoldTime.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersKeepalive.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersOutDelay.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupV4OverV6Nh.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeer.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerAdvertiseLbw.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDescription.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDisableIpv4Afi.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerEgressPolicy.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerHoldTime.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerIngressPolicy.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLinkBandwidth.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLocalAddr.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerMaxRoutes.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop4.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop6.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHopSelf.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPassive.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerGroup.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRemoteAsn.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRrClient.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerV4OverV6Nh.h",
"commands/config/protocol/bgp/policy/CmdConfigProtocolBgpPolicy.h",
"commands/config/protocol/bgp/policy/as-path-list/BgpAsPathListCliUtils.h",
"commands/config/protocol/bgp/policy/as-path-list/CmdConfigProtocolBgpPolicyAsPathList.h",
"commands/config/protocol/bgp/policy/as-path-list/entry/CmdConfigProtocolBgpPolicyAsPathListEntry.h",
"commands/config/protocol/bgp/policy/community-list/BgpCommunityListCliUtils.h",
"commands/config/protocol/bgp/policy/community-list/CmdConfigProtocolBgpPolicyCommunityList.h",
"commands/config/protocol/bgp/policy/community-list/community/CmdConfigProtocolBgpPolicyCommunityListCommunity.h",
"commands/config/protocol/bgp/policy/prefix-list/BgpPrefixListCliUtils.h",
"commands/config/protocol/bgp/policy/prefix-list/CmdConfigProtocolBgpPolicyPrefixList.h",
"commands/config/protocol/bgp/policy/prefix-list/entry/CmdConfigProtocolBgpPolicyPrefixListEntry.h",
"commands/config/protocol/bgp/policy/routing-policy/CmdConfigProtocolBgpPolicyRoutingPolicy.h",
"commands/config/protocol/static/CmdConfigProtocolStatic.h",
"commands/config/protocol/static/route/StaticRouteUtils.h",
"commands/config/protocol/static/route/add/CmdConfigProtocolStaticRouteAdd.h",
Expand Down Expand Up @@ -1337,6 +1278,14 @@ cpp_library(
"commands/delete/interface/ipv6/CmdDeleteInterfaceIpv6.h",
"commands/delete/interface/ipv6/ndp/CmdDeleteInterfaceIpv6Ndp.h",
"commands/delete/protocol/CmdDeleteProtocol.h",
"commands/delete/protocol/bgp/CmdDeleteProtocolBgp.h",
"commands/delete/protocol/bgp/neighbor/CmdDeleteProtocolBgpNeighbor.h",
"commands/delete/protocol/bgp/peer-group/CmdDeleteProtocolBgpPeerGroup.h",
"commands/delete/protocol/bgp/policy/CmdDeleteProtocolBgpPolicy.h",
"commands/delete/protocol/bgp/policy/as-path-list/CmdDeleteProtocolBgpPolicyAsPathList.h",
"commands/delete/protocol/bgp/policy/community-list/CmdDeleteProtocolBgpPolicyCommunityList.h",
"commands/delete/protocol/bgp/policy/prefix-list/CmdDeleteProtocolBgpPolicyPrefixList.h",
"commands/delete/protocol/bgp/policy/routing-policy/CmdDeleteProtocolBgpPolicyRoutingPolicy.h",
"commands/delete/protocol/static/CmdDeleteProtocolStatic.h",
"commands/delete/protocol/static/route/CmdDeleteProtocolStaticRoute.h",
"commands/delete/qos/CmdDeleteQos.h",
Expand Down
Loading
Loading