Allow runCmds to change user.#1772
Open
JensGroenborgAndersen wants to merge 3 commits intofabric8io:masterfrom
Open
Allow runCmds to change user.#1772JensGroenborgAndersen wants to merge 3 commits intofabric8io:masterfrom
JensGroenborgAndersen wants to merge 3 commits intofabric8io:masterfrom
Conversation
JensGroenborgAndersen
force-pushed
the
master
branch
4 times, most recently
from
3ecaead to
355f7b4
Compare
As discussed in fabric8io#913 (comment), except the user tag is not limited to the first entry. A user tag will however disable the optimize option. Signed-off-by: Jens Andersen <jega@dbc.dk>
JensGroenborgAndersen
force-pushed
the
master
branch
from
355f7b4 to
c47e054
Compare
Signed-off-by: Jens Andersen <jega@dbc.dk>
|
| @BeforeEach | ||
| void containerSetup() throws ComponentLookupException, SecDispatcherException { | ||
| Mockito.lenient().when(container.lookup(SecDispatcher.ROLE, "maven")).thenReturn(secDispatcher); | ||
| // Mockito.lenient().when(container.lookup(SecDispatcher.ROLE, "maven")).thenReturn(secDispatcher); |
Member
There was a problem hiding this comment.
Why is this mockito expectation commented out?
Author
There was a problem hiding this comment.
Ugh i guess I forgot about those. As i remember, it happened because the Security dispatcher stuff doesn't work with never versions of maven. I guess it should be enabled, so that whoever knows how it is supposed to work can make the appropriate fixes.
| // throw new MojoExecutionException("Error looking security dispatcher",e); | ||
| // } catch (ReflectiveOperationException e) { | ||
| // throw new MojoExecutionException("Cannot decrypt password: " + e.getCause(),e); | ||
| // } |
Member
There was a problem hiding this comment.
This code is used for decrypting password from maven settings.xml . Why is this commented out? Disabling this might cause problems for users who are using encryption with maven
Signed-off-by: Jens Andersen <jega@dbc.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #913 (comment), except the user tag is not limited to the first entry. A user tag will however disable the optimize option