Skip to content

Use relative paths for require#11

Closed
alexjfisher wants to merge 1 commit into
f5devcentral:masterfrom
alexjfisher:fix_require
Closed

Use relative paths for require#11
alexjfisher wants to merge 1 commit into
f5devcentral:masterfrom
alexjfisher:fix_require

Conversation

@alexjfisher

Copy link
Copy Markdown
Contributor

Apply the same fix as 8c45870 to the new types.

The providers work fine with puppet resource, but with puppetserver 2.8 I was getting...

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Sta
tement, Could not autoload puppet/type/f5_ntp: Could not autoload puppet/provider/f5_ntp/rest: no such file to load -- puppet/provider/f5 at /etc/puppetlabs/code/environments/f5_test/roles_and_profiles/profi
le/manifests/f5.pp:6:3 on node f5-test-web-lb.example.com

Apply the same fix as
f5devcentral@8c45870
to the new types.
@bastelfreak

Copy link
Copy Markdown

I actually had the same issues on my own module. Fixed it with the same adjustments, so verified that this patchset works.

@abrader

abrader commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

@alexjfisher any chance you can resubmit this PR against development branch of this repo? Not trying to be a pain but need to restructure how PRs come in for @ericzji so he can release with ease but be fair to community.

@alexjfisher

Copy link
Copy Markdown
Contributor Author

@abrader Hi! It's not a problem or a pain to target a different branch with my PRs. I did spot the development branch, but it wasn't clear I should be using that. Given its recent commit history I thought it was maybe going to be rebased/squashed at any time before being merging to master. If the plan is to use a gitflow style of development, (which is perhaps a bit unusual on github - especially with puppet modules), I can work with that.

Most importantly to me, I'm really pleased you got in touch. I had began to worry a bit that the module was open source but not looking for external contributions. It's a relief to hear otherwise! :)

@alexjfisher

Copy link
Copy Markdown
Contributor Author

Resubmitted against development in #15

@alexjfisher

Copy link
Copy Markdown
Contributor Author

@abrader Taking a closer look, the development branch has been deleted and recreated several times over the last couple of months. Are you sure this is going to work out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants