refactor: make application configuration portable - #140
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f0rr0
marked this pull request as ready for review
September 9, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forks currently inherit personal GitHub account assumptions, metadata and service configuration. This change makes those inputs configurable while retaining the existing personal content and assets.
GitHub authors are configured once in public profile data;
GITHUB_TOKENSmaps their logins to credentials. Token rotation/removal no longer selects authors or prunes history. Acquisition reuses direct lookup and identity verification, with no account registry, discovery context or new identity column. A forward migration replaces seven personal account constraints and preserves existing checkpoints.Profile metadata, structured exports, PDF links, repository discovery and timezone labels share configured sources. T3 supplies shared environment types and the Vercel preset; native Vercel public variables provide browser deployment identity without custom aliases. Vercel supplies the canonical hostname; Markdown exports reuse compiled image URLs. Builds are independent of migrations/cron, analytics is optional, and direct dependencies retain their existing versions with exact pins. GitHub native secret scanning and push protection are enabled; no additional Gitleaks CI job is introduced.
Validation: 327 tests passed locally, including disposable PostgreSQL upgrades, history-preservation checks, alternate-profile configuration and browser deployment environment checks. A focused PostgreSQL projection rerun also passed after hoisting the author-ID set. All seven shared login constraints produce SQL identical to the existing migration snapshot. Typecheck, lint, formatting and a Vercel-style production build passed; the build retains two existing filesystem-tracing warnings. The earlier redacted source scan found only the known dummy cursor-test secret.
Rollout settings are prepared: Vercel has the token object, optional analytics variables and documented Build Command; GitHub Actions has
ACTIVITY_GITHUB_TOKENS, mapped to the application'sGITHUB_TOKENSvariable. The old token variables are retained during rollout. The PR is not merged and production database migrations/cron updates have not been applied.