feat: add --show-dotfiles#1767
Open
bcullman wants to merge 8 commits intoeza-community:mainfrom
Open
Conversation
7b82c71 to
d4ddab1
Compare
d4ddab1 to
af9aed3
Compare
dfe715a to
91c4efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Unix-like systems, "hidden" usually means a name starts with (
.). On Windows, there is also a separate filesystemhiddenattribute. Because of that,-ais often a reasonable way to show dotfiles on Unix-like systems, but can be much noisier on Windows.Examples:
Unix-like:
Windows:
This PR adds --show-dotfiles as a narrower option:
Unix-like:
Windows:
This helps with a common Windows case where -a is too broad because it also reveals hidden-attribute files and Windows hidden links/aliases.
Some entries in a Windows home directory are also hidden links/aliases rather than regular files or directories. Examples include entries such as Local Settings and SendTo. Links do not have to be hidden in general, but many of these Windows profile links are.
Those entries are intentionally out of scope for this PR. This change focuses only on showing dotfiles without also enabling the broader Windows hidden-attribute view. A sister PR will follow to add a way to show those hidden Windows links/aliases as well.
This is one of the PRs needed to address #1720 #1768